Skip to content

StepperList - Fix type for status #3073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 31, 2025
Merged

StepperList - Fix type for status #3073

merged 3 commits into from
Jul 31, 2025

Conversation

dchyun
Copy link
Contributor

@dchyun dchyun commented Jul 31, 2025 •
edited
Loading

📌 Summary

If merged, this PR would update the type of the status argument in the Stepper::List::Step from HdsStepperStatusesValues to HdsStepperStatuses.

The type of the component currently is incorrectly set to the enum value instead of the type value.

🔗 External links

Jira ticket: HDS-5169

👀 Component checklist

💬 Please consider using conventional comments when reviewing this PR.

📋 PCI review checklist
  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • If applicable, I've worked with GRC to document the impact of any changes to security controls.
    Examples of changes to controls include access controls, encryption, logging, etc.
  • If applicable, I've worked with GRC to ensure compliance due to a significant change to the in-scope PCI environment.
    Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.

@vercel Vercel
Copy link

vercel bot commented Jul 31, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
hds-showcase ✅ Ready (Inspect) Visit Preview Jul 31, 2025 8:54pm
hds-website ✅ Ready (Inspect) Visit Preview Jul 31, 2025 8:54pm

@dchyun dchyun marked this pull request as ready for review July 31, 2025 20:29
@dchyun dchyun requested a review from a team as a code owner July 31, 2025 20:29
shleewhite
shleewhite reviewed Jul 31, 2025
View reviewed changes
KristinLBradley
KristinLBradley approved these changes Jul 31, 2025
View reviewed changes
Copy link
Contributor

@KristinLBradley KristinLBradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Clearer to read & understand too with this change

shleewhite
shleewhite approved these changes Jul 31, 2025
View reviewed changes
Copy link
Contributor

@shleewhite shleewhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@dchyun dchyun merged commit 63d760e into main Jul 31, 2025
16 checks passed
@dchyun dchyun deleted the dchyun/stepper-list-status-type-fix branch July 31, 2025 21:37
@hashibot-hds hashibot-hds mentioned this pull request Jul 30, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shleewhite shleewhite shleewhite approved these changes

@KristinLBradley KristinLBradley KristinLBradley approved these changes

Assignees
No one assigned
Labels
packages/components showcase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dchyun @shleewhite @KristinLBradley @hashibot-hds