HDS-5263: Alert composition change for discussion
#3085
+24
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
MelSumner
changed the title
Alert composition change for discussion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
If merged, this PR re-factors the HTML of the
Alertso that the alert/aria-live div are always in the DOM if the component is used.This would resolve one issue where we had to play around with the positioning of the error conditional in order to get the component to work correctly in the helios-demo app while using assistive tech.
However, since this may have other implications that we may not be aware of, we're only submitting this one small change in order to facilitate a discussion about other details we may not know about yet.
We should probably figure out a way to trigger an error or some other alert-triggering condition on our showcase pages so that we can manually test in a more appropriate way.
🛠️ Detailed description
📸 Screenshots
🔗 External links
Jira ticket: HDS-5263
Figma file: [if it applies]
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.
📋 PCI review checklist
Examples of changes to controls include access controls, encryption, logging, etc.
Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.