Skip to content

Conversation

dchyun
Copy link
Contributor

@dchyun dchyun commented Aug 7, 2025

📌 Summary

This spike is a test of converting the showcase route for the Table to gts and splitting up the template into multiple sub-components.

🔗 External links

Jira ticket: HDS-XXX


👀 Component checklist

  • Percy was checked for any visual regression

💬 Please consider using conventional comments when reviewing this PR.

📋 PCI review checklist
  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • If applicable, I've worked with GRC to document the impact of any changes to security controls.
    Examples of changes to controls include access controls, encryption, logging, etc.
  • If applicable, I've worked with GRC to ensure compliance due to a significant change to the in-scope PCI environment.
    Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.

Copy link

vercel bot commented Aug 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
hds-showcase 🔄 Building (Inspect) Visit Preview Aug 7, 2025 9:22pm
hds-website ✅ Ready (Inspect) Visit Preview Aug 7, 2025 9:22pm

@KristinLBradley
Copy link
Contributor

@dchyun I'm only seeing one minor visual diff in the failing Percy check which looks pretty minor. If it's as expected or not an issue, you could approve the Percy diff to get rid of the failing check.

image

@dchyun
Copy link
Contributor Author

dchyun commented Aug 13, 2025

@dchyun I'm only seeing one minor visual diff in the failing Percy check which looks pretty minor. If it's as expected or not an issue, you could approve the Percy diff to get rid of the failing check.

@KristinLBradley thanks for taking a look. That diff is expected, and I have approved it in Percy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants