Skip to content

Add GCS Getter #170

Merged
azr merged 18 commits intomasterfrom
unknown repository
Mar 6, 2019
Merged

Add GCS Getter #170
azr merged 18 commits intomasterfrom
unknown repository

Conversation

@lifangmoler
Copy link
Copy Markdown
Contributor

@lifangmoler lifangmoler commented Mar 1, 2019 •
edited
Loading

Why?

Add gcs (google cloud storage) as another protocol to download files/directories like S3, Git and others.

In order to pass the integration tests:

  1. Need to add Google Credentials inside get_gcs_test.go
  2. Create gcs buckets and folder/files( for consistency, I created a bucket with the same name to S3)

@hashicorp-cla
Copy link
Copy Markdown

hashicorp-cla commented Mar 1, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@azr azr changed the title Refactor and test Add GCS Getter Mar 4, 2019
azr
azr reviewed Mar 4, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@azr azr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, this looks good to me, nice one and thanks for opening. I tested it and it worked, I just had a question about context usage and I will try to see how we can create that bucket !

Comment thread get_gcs.go Outdated
Comment thread get_gcs_test.go Outdated
lifangmoler and others added 11 commits March 4, 2019 12:06
@lifangmoler
remove extra ctx
a5b9998
@azr
GCS: use newly created go-getter-test bucket
ac99e97
@azr
Merge branch 'master' into refactor_and_test
5f22be6
@azr
Update .travis.yml
4fb8b50 
create google application credentials file from env vars.
@azr
Update .travis.yml
6242402 
quote "$GOOGLE_APPLICATION_CREDENTIALS" to avoid ambiguous redirect
@azr
Update appveyor.yml
04d42a3 
output $GOOGLE_CREDENTIALS to $GOOGLE_APPLICATION_CREDENTIALS
@azr
Update .travis.yml
d0d48d2 
touch "$GOOGLE_APPLICATION_CREDENTIALS" before adding contents to it
@azr
Update appveyor.yml
6243c6b 
    echo %GOOGLE_CREDENTIALS% > %GOOGLE_CREDENTIALS%
@azr
Update get_gcs_test.go
97440f8 
create $GOOGLE_APPLICATION_CREDENTIALS file on the fly from $GOOGLE_CREDENTIALS if needed
@azr
Update .travis.yml
59e64f6 
revert file tests edits
@azr
Update appveyor.yml
d6a3600 
revert file tests edits
@azr
Copy link
Copy Markdown
Contributor

azr commented Mar 5, 2019 •
edited
Loading

Okay I did the testing part and tests are green, yay ! I will squash and merge to clean the commit mess.

And sorry, I forgot, could you please add doc about this getter in the README ? Otherwise this looks good to merge :)

@lifangmoler
Copy link
Copy Markdown
Contributor Author

lifangmoler commented Mar 5, 2019

@azr I have updated the README doc

azr
azr approved these changes Mar 6, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@azr azr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, thanks @lifangmoler !!! 🙂

@azr azr merged commit 0be63f2 into hashicorp:master Mar 6, 2019
@davewongillies davewongillies mentioned this pull request Apr 18, 2019
Closed
@davewongillies davewongillies mentioned this pull request May 8, 2019
Merged
@ExalDraen ExalDraen mentioned this pull request May 21, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@azr azr azr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lifangmoler @hashicorp-cla @azr