Remove omission of vcs_repo in stack update #1131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maed223
force-pushed
the
remove-omission-of-vcs_repo-in-stack-update
branch
from
68828eb to
8c80322
Compare
Maed223
force-pushed
the
remove-omission-of-vcs_repo-in-stack-update
branch
from
b4bd977 to
618c599
Compare
Maed223
force-pushed
the
remove-omission-of-vcs_repo-in-stack-update
branch
from
618c599 to
3adb691
Compare
|
Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously forgotten in the PR removing the VCS repo validation was to remove the
omit-emptyjsonapi tag in theStackUpdateOptions. This is needed as we need to explicitly givenilin the request to remove the VCS backing of a Stack. Before this wouldn't work as the nil was being omitted from the request. This is a requirement for the tfe provider work.Testing plan
Added a test to cover this change
Output from tests
Rollback Plan