Skip to content

Conversation

hwatkins05-hashicorp
Copy link
Contributor

Description

Added BETA support for approving all plans in a StackDeploymentGroup

Testing plan

  1. Run local Atlas instance with stacks-ga flag disabled
  2. Run associated integration test for stack deployment groups

External links

Output from tests

Including output from tests may require access to a TFE instance. Ignore this section if you have no environment to test against.

% envchain go-tfe go test -run TestStackDeploymentGroupsApproveAllPlans -v
=== RUN   TestStackDeploymentGroupsApproveAllPlans
    stack_deployment_groups_integration_test.go:158: Polling stack "st-xowYPk2x4ztXfwLk" for deployments with deadline of 2025-06-17 16:11:14.811347 -0700 PDT m=+304.519916626
    stack_deployment_groups_integration_test.go:158: ...
    stack_deployment_groups_integration_test.go:158: Stack "st-xowYPk2x4ztXfwLk" had 0 deployments
    stack_deployment_groups_integration_test.go:158: ...
    stack_deployment_groups_integration_test.go:158: Stack "st-xowYPk2x4ztXfwLk" had 0 deployments
    stack_deployment_groups_integration_test.go:158: ...
    stack_deployment_groups_integration_test.go:158: Stack "st-xowYPk2x4ztXfwLk" had 0 deployments
    stack_deployment_groups_integration_test.go:158: ...
    stack_deployment_groups_integration_test.go:158: Stack "st-xowYPk2x4ztXfwLk" had 2 deployments
=== RUN   TestStackDeploymentGroupsApproveAllPlans/Approve_all_plans
--- PASS: TestStackDeploymentGroupsApproveAllPlans (14.33s)
    --- PASS: TestStackDeploymentGroupsApproveAllPlans/Approve_all_plans (0.16s)
PASS
ok      github.com/hashicorp/go-tfe     14.750s

@hwatkins05-hashicorp hwatkins05-hashicorp requested a review from a team as a code owner June 17, 2025 23:09
ctrombley
ctrombley previously approved these changes Jun 17, 2025
Copy link
Collaborator

@ctrombley ctrombley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nice work!

ctrombley
ctrombley previously approved these changes Jun 18, 2025
@datadog-terraform-cloud-hashicorp
Copy link

datadog-terraform-cloud-hashicorp bot commented Jun 18, 2025

Datadog Report

Branch report: hw/approve-deployment-group
Commit report: 5116886
Test service: hashicorp/go-tfe

✅ 0 Failed, 1451 Passed, 185 Skipped, 18m 47.57s Total Time
🔻 Test Sessions change in coverage: 1 decreased (-0.1%)

🔻 Code Coverage Decreases vs Default Branch (1)

  • datadog-ci junit upload 58.7% (-0.1%) - Details

ctrombley
ctrombley previously approved these changes Jun 18, 2025
Copy link
Collaborator

@ctrombley ctrombley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@hwatkins05-hashicorp hwatkins05-hashicorp merged commit 5aecfdd into main Jun 18, 2025
8 checks passed
@hwatkins05-hashicorp hwatkins05-hashicorp deleted the hw/approve-deployment-group branch June 18, 2025 18:00
Copy link

Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants