Skip to content

Stack configuration list endpoint #1138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 20, 2025
Merged

Stack configuration list endpoint #1138

merged 7 commits into from
Jun 20, 2025

Conversation

shwetamurali
Copy link
Contributor

@shwetamurali shwetamurali commented Jun 19, 2025 •
edited
Loading

Description

Adding an endpoint to get the list of corresponding configurations for a given stack ID per the OpenAPI Spec

Testing plan

  1. Fork pet-nulls-stack or any repo with stacks
  2. Disable stacks-ga flag in local atlas
  3. Run test

Output from tests

go test -v -run TestStackConfigurationList

=== RUN   TestStackConfigurationList
=== RUN   TestStackConfigurationList/with_pagination_options
--- PASS: TestStackConfigurationList (8.50s)
    --- PASS: TestStackConfigurationList/with_pagination_options (0.13s)
PASS
ok      github.com/hashicorp/go-tfe     8.894s

@datadog-terraform-cloud-hashicorp
Copy link

datadog-terraform-cloud-hashicorp bot commented Jun 19, 2025 •
edited
Loading

Datadog Report

Branch report: TF-26845-stack-configuration-list
Commit report: a1c3d15
Test service: hashicorp/go-tfe

✅ 0 Failed, 1451 Passed, 186 Skipped, 17m 54.45s Total Time
🔻 Test Sessions change in coverage: 1 decreased (-0.1%)

🔻 Code Coverage Decreases vs Default Branch (1)

  • datadog-ci junit upload 58.6% (-0.1%) - Details

@shwetamurali shwetamurali marked this pull request as ready for review June 19, 2025 02:11
@shwetamurali shwetamurali requested a review from a team as a code owner June 19, 2025 02:11
jpadrianoGo
jpadrianoGo reviewed Jun 19, 2025
View reviewed changes
jpadrianoGo
jpadrianoGo reviewed Jun 19, 2025
View reviewed changes
hwatkins05-hashicorp
hwatkins05-hashicorp previously approved these changes Jun 19, 2025
View reviewed changes
Maed223
Maed223 reviewed Jun 19, 2025
View reviewed changes
@shwetamurali shwetamurali force-pushed the TF-26845-stack-configuration-list branch from d1136bf to c4cf5e5 Compare June 19, 2025 21:25
Maed223
Maed223 approved these changes Jun 20, 2025
View reviewed changes
Copy link
Contributor

@Maed223 Maed223 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@shwetamurali shwetamurali merged commit a9b2933 into main Jun 20, 2025
8 checks passed
@shwetamurali shwetamurali deleted the TF-26845-stack-configuration-list branch June 20, 2025 15:40
@github-actions GitHub Actions
Copy link

Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Maed223 Maed223 Maed223 approved these changes

@hwatkins05-hashicorp hwatkins05-hashicorp hwatkins05-hashicorp left review comments

+1 more reviewer

@jpadrianoGo jpadrianoGo jpadrianoGo left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shwetamurali @jpadrianoGo @Maed223 @hwatkins05-hashicorp