Add support for searching modules in private registry #1179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g and providername
registry_module.go
Outdated
| Provider string `url:"filter[provider],omitempty"` | ||
|
|
||
| // RegistryName filters results by registry name (public or private) | ||
| RegistryName string `url:"filter[registry_name],omitempty"` |
There was a problem hiding this comment.
I noticed the RegistryName field in RegistryModuleListOptions uses string type instead of the RegistryName type used in other areas of the file. This may be intentional for query parameter compatibility, but wanted to confirm in case you weren't aware we had the attribute already!
There was a problem hiding this comment.
yup, you're correct
shwetamurali
previously approved these changes
Aug 11, 2025
shwetamurali
approved these changes
Aug 11, 2025
|
Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes. |
mutahhir
pushed a commit
that referenced
this pull request
Sep 2, 2025
* add support for searching modules in private registry using query, org and providername * changing the registryName data type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
provider,registry_nameandorganization_nameDescription
RegistryModuleListOptionsonly includes limit options for pagination, this would allow users to query modules betterTesting plan
External links
Output from tests
Including output from tests may require access to a TFE instance. Ignore this section if you have no environment to test against.
Rollback Plan
Changes to Security Controls