Updates User API attribute is-site-admin to leverage is-admin #900
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfhodges
force-pushed
the
mfhodges/tf-10833-user-api-leverages-is-admin-attribute
branch
from
565b98f to
45aeb26
Compare
mfhodges
changed the title
brandonc
reviewed
May 15, 2024
mfhodges
commented
May 15, 2024
mfhodges
force-pushed
the
mfhodges/tf-10833-user-api-leverages-is-admin-attribute
branch
from
bc83acd to
87910d2
Compare
mfhodges
force-pushed
the
mfhodges/tf-10833-user-api-leverages-is-admin-attribute
branch
from
87910d2 to
93c1875
Compare
Co-authored-by: Brandon Croft <[email protected]>
mfhodges
force-pushed
the
mfhodges/tf-10833-user-api-leverages-is-admin-attribute
branch
from
93c1875 to
adc4792
Compare
|
Let's add a CHANGELOG entry as well. Be sure to include it under a header called ## Deprecations |
mfhodges
force-pushed
the
mfhodges/tf-10833-user-api-leverages-is-admin-attribute
branch
from
82adf39 to
8c85270
Compare
brandonc
reviewed
May 21, 2024
mfhodges
force-pushed
the
mfhodges/tf-10833-user-api-leverages-is-admin-attribute
branch
from
8c85270 to
74dc153
Compare
brandonc
approved these changes
May 21, 2024
brandonc
deleted the
mfhodges/tf-10833-user-api-leverages-is-admin-attribute
branch
|
Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The User API will be deprecating the
is-site-adminattribute in favor ofis-adminwhich was introduced yesterdayThis is a one-line change since this variable is being referenced anywhere yet in go-tfe.
Docs updates hashicorp/terraform-docs-common#636 will be merged once the next release is cut
Testing plan
External links
Output from tests
Including output from tests may require access to a TFE instance. Ignore this section if you have no environment to test against.