-
Notifications
You must be signed in to change notification settings - Fork 104
Update Org and Run Tasks for Private Run Tasks #944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3ba7a80
to
5ce883c
Compare
7bc320e
to
a0d0245
Compare
a0d0245
to
7f3a1d1
Compare
Datadog ReportBranch report: ✅ 0 Failed, 1451 Passed, 176 Skipped, 17m 18.62s Total Time |
7f3a1d1
to
4119cc2
Compare
4119cc2
to
18a6072
Compare
This commit updates the Org. entitlements for the new Private Run Tasks feature. This commit also updates the Run Task options struct for CRUD operations to pass through the agent pool relationship
18a6072
to
158da44
Compare
// Unfortunately when we create a Run Task it automatically verifies that the URL by sending a test payload. But | ||
// this means with an agent pool, we need an agent pool to exist, and an agent created with request forwarding enabled. | ||
// This is too much to create for this one test suite. So instead, we really only need to assert that; when the options include an | ||
// agent pool, then we expect HCP Terraform to process the agent pool. So, if we send it a nonsense agent pool ID, then we | ||
// expect an error to be returned saying that the ID was nonsense. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes. |
Description
This commit updates the Org. entitlements for the new Private Run Tasks feature. This commit also updates the Run Task options struct for CRUD operations to pass through the agent pool relationship
Testing plan
Handled by integration test changes.
External links
Output from tests
Including output from tests may require access to a TFE instance. Ignore this section if you have no environment to test against.