Make TestNomad_BootstrapExpect_NonVoter stop failing

[shoenig]

TestNomad_BootstrapExpect_NonVoter

This test in particular fails in CI way too often, preventing perfect green PRs. See if we can make it more reliable.

[shoenig]

Seems like this may boil down to improper use of peerLock

WARNING: DATA RACE
Read at 0x00c000499800 by goroutine 39:
  github.com/hashicorp/nomad/nomad.testNomadBootstrapExpectNonVoter.func5()
      /home/shoenig/Work/go/nomad/nomad/aaa_test.go:122 +0x417
  github.com/hashicorp/nomad/testutil.WaitForResultUntil()
      /home/shoenig/Work/go/nomad/testutil/wait.go:44 +0xc6
  github.com/hashicorp/nomad/nomad.testNomadBootstrapExpectNonVoter()
      /home/shoenig/Work/go/nomad/nomad/aaa_test.go:74 +0x4c4
  github.com/hashicorp/nomad/nomad.Test_RunNonVoter()
      /home/shoenig/Work/go/nomad/nomad/aaa_test.go:16 +0x3d
  testing.tRunner()
      /opt/google/go/src/testing/testing.go:1259 +0x22f
  testing.(*T).Run·dwrap·21()
      /opt/google/go/src/testing/testing.go:1306 +0x47

Previous write at 0x00c000499800 by goroutine 232:
  runtime.mapassign_faststr()
      /opt/google/go/src/runtime/map_faststr.go:202 +0x0
  github.com/hashicorp/nomad/nomad.(*Server).nodeJoin()
      /home/shoenig/Work/go/nomad/nomad/serf.go:81 +0x78d
  github.com/hashicorp/nomad/nomad.(*Server).serfEventHandler()
      /home/shoenig/Work/go/nomad/nomad/serf.go:34 +0x21b
  github.com/hashicorp/nomad/nomad.NewServer·dwrap·311()
      /home/shoenig/Work/go/nomad/nomad/server.go:438 +0x39

[shoenig]

hashicorp/raft#492 might have something to do with it

[tgross]

As noted in https://github.com/hashicorp/nomad-enterprise/issues/789, this always fails in ENT currently.

[tgross]

hashicorp/raft#492 might have something to do with it

Looks like the Consul folks agree: hashicorp/consul#12496

[shoenig]

Hopefully fixed by #13944

[github-actions]

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.