Backport of Add historical journald and log export flags to operator debug command into release/1.10.x #26427
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #26410 to be assessed for backporting due to the inclusion of the label backport/1.10.x.
🚨
The person who merged in the original PR is:
@tehut
This person should resolve the merge-conflict(s) by either:
The below text is copied from the body of the original PR.
Description
Support requested the ability to retrieve historical journald logs as part of the debug capture returned by
nomad operator debug
. PR #26178 introduced aMonitorExport()
RPC capable of streaming the contents of an agent's log file (if file logging is enabled) or its journald logs.This PR adds that functionality to
operator debug
with the inclusion of either alog-file-export=true
flag or a-log-lookback=<duration>
flag. An agent's historical log capture runs alongside the capture of running logs and results in bothmonitor.log
andmonitor_export.log
files appearing in each agent's debug capture.Note to reviewers: I exported a test helper from PR #26178 for this new test case. The helper generates a golden log file for testing against stream results. And since the helper is now exported, I also refactored a few tests from that PR to use it as well since they were using the same mechanism.
Testing & Reproduction steps
To run locally:
nomad operator debug -duration=10s -interval=5s -log-file-export=true
monitor.log
andmonitor_export.log
file for each agent in the cluster.
Example below
Links
Requested in: NMD-141
Contributor Checklist
changelog entry using the
make cl
command.ensure regressions will be caught.
and job configuration, please update the Nomad website documentation to reflect this. Refer to
the website README for docs guidelines. Please also consider whether the
change requires notes within the upgrade guide.
Reviewer Checklist
backporting document.
in the majority of situations. The main exceptions are long-lived feature branches or merges where
history should be preserved.
within the public repository.
Overview of commits