docs: revert to labels={"foo.bar": "baz"} style #26535
Merged
+171
−177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Back in #24074 I thought it was necessary to wrap labels in a list to support quoted keys in hcl2. This... doesn't appear to be true at all? The simpler `labels={...}` syntax appears to work just fine. I updated the docs and a test (and modernized it a bit). I also switched some other examples to the `labels = {}` format from the old `labels{}` format.
schmichael
commented
Aug 15, 2025
| no_copy = true | ||
| labels = { | ||
| label_key = "label_value" | ||
| "dotted.keys" = "always work" |
There was a problem hiding this comment.
New entry. (Sorry the new file and formatting makes it hard to spot)
schmichael
commented
Aug 15, 2025
| labels = { | ||
| owner = "hashicorp-nomad" | ||
| key = "val" | ||
| "dotted.keys" = "work" |
There was a problem hiding this comment.
New entry. (Sorry the new file and formatting makes it hard to spot)
aimeeu
approved these changes
Aug 18, 2025
tgross
added
backport/website
This was referenced Aug 20, 2025
schmichael
added a commit
that referenced
this pull request
Aug 20, 2025
Backport of just the docs update from #26535
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Back in #24074 I thought it was necessary to wrap labels in a list to support quoted keys in hcl2. This... doesn't appear to be true at all? The simpler
labels={...}syntax appears to work just fine.I updated the docs and a test (and modernized it a bit). I also switched some other examples to the
labels = {}format from the oldlabels{}format.Description
Testing & Reproduction steps
Links
Contributor Checklist
changelog entry using the
make clcommand.ensure regressions will be caught.
and job configuration, please update the Nomad website documentation to reflect this. Refer to
the website README for docs guidelines. Please also consider whether the
change requires notes within the upgrade guide.
Reviewer Checklist
backporting document.
in the majority of situations. The main exceptions are long-lived feature branches or merges where
history should be preserved.
within the public repository.