Fixing tests using consul for dns #232
Conversation
bump 'min_packer_version' -> 1.5.4 bump 'vault_version' -> 1.6.1 bump 'consul_version' -> 1.9.2
Adding 'service_registration' used when using a different storage backend like 's3' Updating systemd configuration based on this documentation https://learn.hashicorp.com/tutorials/vault/deployment-guide\#step-3-configure-systemd
Add a new test stage 'initialize_unseal' useful when running multiple times the 'validation' stage against the same cluster Add 'testVaultUsesConsulForDns' for all test cases
brikis98
left a comment
brikis98
left a comment
There was a problem hiding this comment.
Very nice, thanks! Just some minor NITs, and then I can kick off tests.
…ariable for the address of the consul agent to communicate with
…registration-address parameter
brikis98
left a comment
brikis98
left a comment
There was a problem hiding this comment.
This looks great, thank you! I'll kick off tests now.
brikis98
left a comment
brikis98
left a comment
There was a problem hiding this comment.
Thanks! Just one comment and then I can kick off tests.
brikis98
left a comment
brikis98
left a comment
There was a problem hiding this comment.
Thanks! I'll kick off tests.
|
Tests passed! 🎉 So does this imply there's no actual bug with #228 / Ubuntu 18.04? That it was just that the service wasn't being registered? Or did we need newer Consul / Vault versions? |
Sorry, crazy week, just coming back to this now. That's great news, thank you! I'm going to merge and release this now. |
2 participants
initialize_unsealuseful when running multiple times thevalidationstage against the same clustertestVaultUsesConsulForDnsfor all test casesservice_registrationused when using a different storage backend likes3systemdconfiguration based on this configure-systemd documentationmin_packer_version->1.5.4vault_version->1.6.1consul_version->1.9.2