Skip to content

Conversation

bendog
Copy link

@bendog bendog commented Aug 25, 2025

Related issue

Fixes #2321 (probably others too)

Description

Previously the CDKTF CLI was giving a false positive match for Pipenv as the packaging tool if Pipenv was installed on the system. It is incredibly common to have Pipenv installed but not in use for a Python project.

I've also added additional support for Poetry and UV package managers (which are both more popular than Pipenv).

Checklist

  • I have updated the PR title to match CDKTF's style guide
  • I have run the linter on my code locally
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation if applicable
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works if applicable
  • New and existing unit tests pass locally with my changes

@bendog bendog requested a review from a team as a code owner August 25, 2025 10:41
@bendog bendog requested review from mutahhir and ansgarm and removed request for a team August 25, 2025 10:41
@bendog bendog changed the title WIP: Fixed bug where pipenv was always created, added support for poetry and uv python package managers fix(lib): Fixed bug where pipenv was always created, added support for poetry and uv python package managers Aug 25, 2025
@bendog
Copy link
Author

bendog commented Aug 25, 2025

I'm having a lot of trouble getting the tests to run, all tests are failing.
Wouldn't mind some feedback on this before I progress any further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cdktf tries to use pipenv even tho I have removed it from cdktf.json
1 participant