Disallow null resource identities #1193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
bbasata
commented
Jul 28, 2025
austinvalle
reviewed
Jul 29, 2025
There was a problem hiding this comment.
Code LGTM, as you mentioned, should probably point to the GH ref of terraform-plugin-go after that is merged.
Also looks like one of the corner resource's needs to be updated to actually set identity, a good catch! 👍🏻 (Also looks like there is an extra log statement in there 😆 )
1 task
Closed
1 task
1 task
|
hashicorp/terraform-provider-corner#382 will resolve the test failures here |
1 task
ansgarm
approved these changes
Sep 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixes #1184. Depends on hashicorp/terraform-plugin-go#541.
Description
This pull request updates the
ReadResourceandApplyResourceChangeRPCs to return an error diagnostic on the Create, Read, and Update paths when a null resource identity would be returned for a resource that has an identity schema.Rollback Plan
Changes to Security Controls
None.