Skip to content

Conversation

bbasata
Copy link
Contributor

@bbasata bbasata commented Sep 17, 2025

Description

I noticed something was missing when I ran TF_LOG=trace terraform query today:

2025-09-16T14:23:38.070-0400 [TRACE] provider.terraform-provider-cloudlite: Checking ResourceTypes lock: @caller=/Users/baraa.basata/go/pkg/mod
/github.com/hashicorp/terraform-plugin-framework@v1.16.0-beta.1.0.20250911064719-2607d454c868/internal/logging/framework.go:29 @module=sdk.framework new_logger_warning="This log was generated by an SDK subsystem logger that wasn't created before being used. Use tflog.NewSubsystem to create this logger before it is used." timestamp=2025-09-16T14:23:36.190-0400

This pull request adds common Go context setup to the Framework implementations of ListResource() and ValidateListResourceConfig(). These two lines result in more correct behavior re: context cancellation and logging.

Rollback Plan

  • If a change needs to be reverted, we will roll out an update to the code within 7 days.

Changes to Security Controls

None.

@bbasata bbasata changed the title Add context setup to proto{5,6}server ListResource() Add context setup to proto{5,6}server ListResource() Sep 17, 2025
Copy link
Contributor Author

@bbasata bbasata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Green checks may be dependent on hashicorp/terraform-provider-corner#377

@bbasata bbasata force-pushed the list-resource-context branch from c10e995 to 9197cb5 Compare September 17, 2025 00:20
@bbasata bbasata marked this pull request as ready for review September 17, 2025 00:20
@bbasata bbasata requested a review from a team as a code owner September 17, 2025 00:20
Copy link
Member

@austinvalle austinvalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice catch! 🚀 CI is related to us not having a TF core version that supports the recent protocol changes we made, will be resolved when bumping 1.14 from alpha to beta 👍🏻

@austinvalle austinvalle merged commit 559599f into main Sep 17, 2025
40 of 76 checks passed
@austinvalle austinvalle deleted the list-resource-context branch September 17, 2025 11:49
@austinvalle austinvalle added this to the v1.16.0 milestone Sep 17, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants