tfprotov5+tfprotov6: Update to protocol versions 5.4/6.4 with GetMetadata RPC and GetProviderSchemaOptional server capability#311
Merged
Conversation
26e2027 to
88d4ba1
Compare
d8073a4 to
31d1908
Compare
This was referenced Aug 30, 2023
Contributor
Author
|
|
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #310
The CI failures for terraform-provider-corner are expected in this case. Protocol upgrades that impose new RPCs will either require:
tfprotov5.ProviderServer/tfprotov6.ProviderServerinterface to require a new methodProviderServerWithGetMetadatain this case)terraform-plugin-go is a low level abstraction which is designed to directly implement the protocol rather than introduce its own abstractions. Most provider developers will directly interface with higher level Go modules, such as terraform-plugin-sdk and terraform-plugin-framework. Except for advanced provider development using this Go module directly, this type of low level "breaking" change will be hidden by also upgrading those Go modules at the same time:
GetProviderSchemaOptionalserver capability terraform-plugin-sdk#1235GetProviderSchemaOptionalserver capability terraform-plugin-framework#829Therefore the change is implemented on the existing interface. terraform-provider-corner happens to also implement its own terraform-plugin-go based provider server code, which is affected by this change. Upgrading the various dependencies and implementing the new method makes terraform-provider-corner testing successful, which can be seen with hashicorp/terraform-provider-corner#174. The CI of this Go module and terraform-provider-corner implementation details just happens to be a chicken-and-egg problem which tends to only come up in this particular type of functionality change. 🐔 🥚