[Attribute Deprecation]: deprecate `block_duration_minutes` from `aws_spot_instance_request` resource

[DanielRieske]

Description

The test TestAccEC2SpotInstanceRequest_withBlockDuration mentioned in #35747 is failing because the block_duration_minutes argument in RequestSpotInstancesInput has been deprecated.

You cannot set this argument anymore, if you do you get the following API respone:

api error InvalidParameterValue: BlockDurationMinutes is not a valid parameter.

After the SDKv2 migration of this resource here, I will create a PR for the removal of the argument so we can release it with the next major version.

This issue is purely for visibility for the argument at hand but we might need to review this resource altogether.
It's currently strongly discouraged to use RequestSpotInstances action within it.

Affected Resource(s) and/or Data Source(s)

aws_spot_instance_request

Potential Terraform Configuration

No response

References

No response

Would you like to implement a fix?

Yes

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

• If you are interested in working on this issue, please leave a comment.
• If this would be your first contribution, please review the contribution guide.

[nam054]

Closed by #42060