[Enhancement]: `d/aws_ami`: Upgrade warning diagnostic to a suppressible error

[jar-b]

Description

#40197 documented the use case for a warning diagnostic on the aws_ami data source to notify practitioners of certain cases when filtering criteria are missing. In v6.0.0 of the AWS provider, this warning diagnostic should be changed to an error diagnostic which can be suppressed by setting a new, optional argument ignore_missing_filter_error (naming TBD).

Affected Resource(s) and/or Data Source(s)

• aws_ami

Potential Terraform Configuration

# Example affected configuration
#
# - most_recent is true
# - owners is not set
# - there are no filters on owner-id or image-id
data "aws_ami" "test" {
  most_recent = true

  filter {
    name   = "architecture"
    values = ["x86_64"]
  }

  filter {
    name   = "name"
    values = ["ubuntu/images/hvm-ssd/ubuntu-focal-20.04-amd64-server-*"]
  }
  
  # This argument will allow the data source to continue to be used with
  # the same filters prior to this change
  ignore_missing_filter_error = true
}

References

Relates #40197
Relates #14158
Relates #25566
Relates #25521

Would you like to implement a fix?

Yes

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

• If you are interested in working on this issue, please leave a comment.
• If this would be your first contribution, please review the contribution guide.

[YakDriver]

I recommend the new optional argument be called allow_unsafe_filter.

[jar-b]

Closed via #42114. These changes will be available in the v6.0.0 beta release later this month.

[github-actions]

Warning

This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.