[WIP] aws_globalaccelerator_custom_routing_accelerator

[YvanGuidoin]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #16690

Output from acceptance testing:

$ make testacc TESTS=TestAccXXX PKG=globalaccelerator

...

TODO:

• Testing
• Traffic allow/deny
• Avoid massive duplication for accelerator and accelerator_attributes

Issues:

AllowCustomRoutingTraffic and DenyCustromRoutingTraffic current state reading is not clear to me

[NetDevAutomate]

@YvanGuidoin Great work on this resource! Are you still working on this resource, and if so is there is any support you need, please let me know? I've emailed you privately with some additional detail.

Again, thank you very much for the great work done and really looking forward to seeing this added to the Provider.

[YvanGuidoin]

Hi, I was working on another part of our system, but we still need it so I will come back to it soon.

[AdamTylerLynch]

@YvanGuidoin please let @NetDevAutomate and myself know if you need any help! We are happy to roll up our sleeves and and write some code if you want!

[YvanGuidoin]

@AdamTylerLynch I added a bit more tests, but no idea how to test properly the aws_globalaccelerator_custom_routing_endpoint_group as spinning up endpoints automatically seems unclear to me.

Should I put the PR up for review for now and leave it up to you guys ?

[julianxhokaxhiu]

@AdamTylerLynch can you please have a look at this? We're also in need of using custom routing and it's a shame is not yet available on the provider.

[julianxhokaxhiu]

@YvanGuidoin Would you also be able to rebase your fork so this PR has no more conflicts in place when @AdamTylerLynch comes around for a review? Thank you!

[amontalban]

Thank you very much for doing this @YvanGuidoin!

We are really interested in seeing this merged ASAP as it is blocking us to have everything codified in Terraform 🙏

[amontalban]

@AdamTylerLynch @NetDevAutomate do you think this is good to go? It would be great to have this natively in the provider instead of doing dozens of AWS CLI calls in Terraform.

Thanks!

[github-actions]

This functionality has been released in v4.61.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.