Skip to content

[WIP] aws_globalaccelerator_custom_routing_accelerator #22162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

YvanGuidoin
Copy link
Contributor

@YvanGuidoin YvanGuidoin commented Dec 10, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #16690

Output from acceptance testing:

$ make testacc TESTS=TestAccXXX PKG=globalaccelerator

...

TODO:

  • Testing
  • Traffic allow/deny
  • Avoid massive duplication for accelerator and accelerator_attributes

Issues:

AllowCustomRoutingTraffic and DenyCustromRoutingTraffic current state reading is not clear to me

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. size/XL Managed by automation to categorize the size of a PR. service/globalaccelerator Issues and PRs that pertain to the globalaccelerator service. and removed needs-triage Waiting for first response or review from a maintainer. labels Dec 10, 2021
@github-actions github-actions bot added the tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. label Dec 13, 2021
@AdamTylerLynch AdamTylerLynch self-requested a review January 31, 2022 18:42
@NetDevAutomate
Copy link
Contributor

@YvanGuidoin Great work on this resource! Are you still working on this resource, and if so is there is any support you need, please let me know? I've emailed you privately with some additional detail.

Again, thank you very much for the great work done and really looking forward to seeing this added to the Provider.

@YvanGuidoin
Copy link
Contributor Author

Hi, I was working on another part of our system, but we still need it so I will come back to it soon.

@AdamTylerLynch
Copy link
Collaborator

@YvanGuidoin please let @NetDevAutomate and myself know if you need any help! We are happy to roll up our sleeves and and write some code if you want!

@github-actions github-actions bot added provider Pertains to the provider itself, rather than any interaction with AWS. and removed provider Pertains to the provider itself, rather than any interaction with AWS. labels Feb 7, 2022
@YvanGuidoin
Copy link
Contributor Author

YvanGuidoin commented Feb 7, 2022

@AdamTylerLynch I added a bit more tests, but no idea how to test properly the aws_globalaccelerator_custom_routing_endpoint_group as spinning up endpoints automatically seems unclear to me.

Should I put the PR up for review for now and leave it up to you guys ?

@YvanGuidoin YvanGuidoin marked this pull request as ready for review March 4, 2022 18:59
@julianxhokaxhiu
Copy link

@AdamTylerLynch can you please have a look at this? We're also in need of using custom routing and it's a shame is not yet available on the provider.

@julianxhokaxhiu
Copy link

@YvanGuidoin Would you also be able to rebase your fork so this PR has no more conflicts in place when @AdamTylerLynch comes around for a review? Thank you!

@github-actions github-actions bot added the provider Pertains to the provider itself, rather than any interaction with AWS. label Aug 26, 2022
@amontalban
Copy link

Thank you very much for doing this @YvanGuidoin!

We are really interested in seeing this merged ASAP as it is blocking us to have everything codified in Terraform 🙏

@amontalban
Copy link

@AdamTylerLynch @NetDevAutomate do you think this is good to go? It would be great to have this natively in the provider instead of doing dozens of AWS CLI calls in Terraform.

Thanks!

@github-actions
Copy link

This functionality has been released in v4.61.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented May 1, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
provider Pertains to the provider itself, rather than any interaction with AWS. service/globalaccelerator Issues and PRs that pertain to the globalaccelerator service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants