[WIP] Consistent Resource Id Separators for resources

[brittandeyoung]

Description

This will implement a standard Id separator for use when writing resources that AWS does not provide a unique id for. Helper functions for this standard Id separator will be included as well to make working with the standard Id simple.

Relations

Closes #27843

References

Output from Acceptance Testing

$ make testacc TESTS=TestAccXXX PKG=ec2

...

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[brittandeyoung]

This is Currently a work in progress, I am looking for feedback from the provider team on the structure of the shared separator logic before updating all the resources in scope.

[brittandeyoung]

Test outputs for the included example resources after the update:

 make testacc TESTARGS='-run=TestAccLightsailDomainEntry' PKG=lightsail
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lightsail/... -v -count 1 -parallel 20  -run=TestAccLightsailDomainEntry -timeout 180m
=== RUN   TestAccLightsailDomainEntry_basic
=== PAUSE TestAccLightsailDomainEntry_basic
=== RUN   TestAccLightsailDomainEntry_disappears
=== PAUSE TestAccLightsailDomainEntry_disappears
=== CONT  TestAccLightsailDomainEntry_basic
=== CONT  TestAccLightsailDomainEntry_disappears
--- PASS: TestAccLightsailDomainEntry_disappears (32.18s)
--- PASS: TestAccLightsailDomainEntry_basic (33.09s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/lightsail  35.113s

make testacc TESTARGS='-run=TestAccBudgets' PKG=budgets
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/budgets/... -v -count 1 -parallel 20  -run=TestAccBudgets -timeout 180m
=== RUN   TestAccBudgetsBudgetAction_basic
=== PAUSE TestAccBudgetsBudgetAction_basic
=== RUN   TestAccBudgetsBudgetAction_disappears
=== PAUSE TestAccBudgetsBudgetAction_disappears
=== RUN   TestAccBudgetsBudget_basic
=== PAUSE TestAccBudgetsBudget_basic
=== RUN   TestAccBudgetsBudget_Name_generated
=== PAUSE TestAccBudgetsBudget_Name_generated
=== RUN   TestAccBudgetsBudget_namePrefix
=== PAUSE TestAccBudgetsBudget_namePrefix
=== RUN   TestAccBudgetsBudget_disappears
=== PAUSE TestAccBudgetsBudget_disappears
=== RUN   TestAccBudgetsBudget_autoAdjustDataForecast
=== PAUSE TestAccBudgetsBudget_autoAdjustDataForecast
=== RUN   TestAccBudgetsBudget_autoAdjustDataHistorical
=== PAUSE TestAccBudgetsBudget_autoAdjustDataHistorical
=== RUN   TestAccBudgetsBudget_costTypes
=== PAUSE TestAccBudgetsBudget_costTypes
=== RUN   TestAccBudgetsBudget_notifications
=== PAUSE TestAccBudgetsBudget_notifications
=== RUN   TestAccBudgetsBudget_plannedLimits
=== PAUSE TestAccBudgetsBudget_plannedLimits
=== CONT  TestAccBudgetsBudgetAction_basic
=== CONT  TestAccBudgetsBudget_autoAdjustDataForecast
=== CONT  TestAccBudgetsBudget_Name_generated
=== CONT  TestAccBudgetsBudget_disappears
=== CONT  TestAccBudgetsBudget_costTypes
=== CONT  TestAccBudgetsBudgetAction_disappears
=== CONT  TestAccBudgetsBudget_autoAdjustDataHistorical
=== CONT  TestAccBudgetsBudget_notifications
=== CONT  TestAccBudgetsBudget_plannedLimits
=== CONT  TestAccBudgetsBudget_namePrefix
=== CONT  TestAccBudgetsBudget_basic
--- PASS: TestAccBudgetsBudget_disappears (24.39s)
--- PASS: TestAccBudgetsBudget_namePrefix (24.63s)
--- PASS: TestAccBudgetsBudget_basic (25.39s)
--- PASS: TestAccBudgetsBudget_autoAdjustDataForecast (26.77s)
--- PASS: TestAccBudgetsBudget_Name_generated (27.30s)
--- PASS: TestAccBudgetsBudgetAction_basic (36.60s)
--- PASS: TestAccBudgetsBudget_costTypes (37.15s)
--- PASS: TestAccBudgetsBudget_autoAdjustDataHistorical (37.89s)
--- PASS: TestAccBudgetsBudget_notifications (41.79s)
--- PASS: TestAccBudgetsBudget_plannedLimits (42.70s)
--- PASS: TestAccBudgetsBudgetAction_disappears (73.94s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/budgets    75.976s