Skip to content

feat: add deletion protection for verifiedpermissions_policy_store #43452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

stefanfreitag
Copy link
Contributor

@stefanfreitag stefanfreitag commented Jul 19, 2025

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

No changes to security controls.

Description

Add deletion protection support for the Amazon Verified Permissions Policy Store.

Relations

Closes #43330

References

Output from Acceptance Testing

Resource

make testacc TESTS=TestAccVerifiedPermissionsPolicyStore  PKG=verifiedpermissions
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.24.5 test ./internal/service/verifiedpermissions/... -v -count 1 -parallel 20 -run='TestAccVerifiedPermissionsPolicyStore'  -timeout 360m -vet=off
2025/07/19 11:48:11 Creating Terraform AWS Provider (SDKv2-style)...
2025/07/19 11:48:11 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccVerifiedPermissionsPolicyStoreDataSource_basic
=== PAUSE TestAccVerifiedPermissionsPolicyStoreDataSource_basic
=== RUN   TestAccVerifiedPermissionsPolicyStoreDataSource_tags
=== PAUSE TestAccVerifiedPermissionsPolicyStoreDataSource_tags
=== RUN   TestAccVerifiedPermissionsPolicyStore_basic
=== PAUSE TestAccVerifiedPermissionsPolicyStore_basic
=== RUN   TestAccVerifiedPermissionsPolicyStore_update
=== PAUSE TestAccVerifiedPermissionsPolicyStore_update
=== RUN   TestAccVerifiedPermissionsPolicyStore_deletionProtection
=== PAUSE TestAccVerifiedPermissionsPolicyStore_deletionProtection
=== RUN   TestAccVerifiedPermissionsPolicyStore_disappears
=== PAUSE TestAccVerifiedPermissionsPolicyStore_disappears
=== RUN   TestAccVerifiedPermissionsPolicyStore_tags
=== PAUSE TestAccVerifiedPermissionsPolicyStore_tags
=== CONT  TestAccVerifiedPermissionsPolicyStoreDataSource_basic
=== CONT  TestAccVerifiedPermissionsPolicyStore_deletionProtection
=== CONT  TestAccVerifiedPermissionsPolicyStore_tags
=== CONT  TestAccVerifiedPermissionsPolicyStore_disappears
=== CONT  TestAccVerifiedPermissionsPolicyStoreDataSource_tags
=== CONT  TestAccVerifiedPermissionsPolicyStore_update
=== CONT  TestAccVerifiedPermissionsPolicyStore_basic
--- PASS: TestAccVerifiedPermissionsPolicyStoreDataSource_basic (37.80s)
--- PASS: TestAccVerifiedPermissionsPolicyStoreDataSource_tags (37.80s)
--- PASS: TestAccVerifiedPermissionsPolicyStore_disappears (42.71s)
--- PASS: TestAccVerifiedPermissionsPolicyStore_basic (44.18s)
--- PASS: TestAccVerifiedPermissionsPolicyStore_update (55.10s)
--- PASS: TestAccVerifiedPermissionsPolicyStore_deletionProtection (70.67s)
--- PASS: TestAccVerifiedPermissionsPolicyStore_tags (76.81s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/verifiedpermissions        77.027s

Data source

make testacc TESTS=TestAccVerifiedPermissionsPolicyStoreDataSource  PKG=verifiedpermissions
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.24.5 test ./internal/service/verifiedpermissions/... -v -count 1 -parallel 20 -run='TestAccVerifiedPermissionsPolicyStoreDataSource'  -timeout 360m -vet=off
2025/07/19 12:41:36 Creating Terraform AWS Provider (SDKv2-style)...
2025/07/19 12:41:36 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccVerifiedPermissionsPolicyStoreDataSource_basic
=== PAUSE TestAccVerifiedPermissionsPolicyStoreDataSource_basic
=== RUN   TestAccVerifiedPermissionsPolicyStoreDataSource_tags
=== PAUSE TestAccVerifiedPermissionsPolicyStoreDataSource_tags
=== CONT  TestAccVerifiedPermissionsPolicyStoreDataSource_basic
=== CONT  TestAccVerifiedPermissionsPolicyStoreDataSource_tags
--- PASS: TestAccVerifiedPermissionsPolicyStoreDataSource_tags (25.83s)
--- PASS: TestAccVerifiedPermissionsPolicyStoreDataSource_basic (25.83s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/verifiedpermissions        26.055s

Copy link

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/verifiedpermissions Issues and PRs that pertain to the verifiedpermissions service. size/M Managed by automation to categorize the size of a PR. external-maintainer Contribution from a trusted external contributor. labels Jul 19, 2025
@stefanfreitag stefanfreitag marked this pull request as ready for review July 19, 2025 12:35
@stefanfreitag stefanfreitag requested a review from a team as a code owner July 19, 2025 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. external-maintainer Contribution from a trusted external contributor. needs-triage Waiting for first response or review from a maintainer. service/verifiedpermissions Issues and PRs that pertain to the verifiedpermissions service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: aws_verifiedpermissions_policy_store deletion protection
1 participant