Skip to content

bug: fix aws_dms_replication_task waiter issue #43467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aristosvo
Copy link
Contributor

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Description

If a task is already stopped due to finishing it's task, the stop reason needs to be checked to validate the reason to make sure its maybe already finished

	// The reason the replication task was stopped. This response parameter can return
	// one of the following values:
	//
	//   - "Stop Reason NORMAL" – The task completed successfully with no additional
	//   information returned.
	//
	//   - "Stop Reason RECOVERABLE_ERROR"
	//
	//   - "Stop Reason FATAL_ERROR"
	//
	//   - "Stop Reason FULL_LOAD_ONLY_FINISHED" – The task completed the full load
	//   phase. DMS applied cached changes if you set StopTaskCachedChangesApplied to
	//   true .
	//
	//   - "Stop Reason STOPPED_AFTER_FULL_LOAD" – Full load completed, with cached
	//   changes not applied
	//
	//   - "Stop Reason STOPPED_AFTER_CACHED_EVENTS" – Full load completed, with cached
	//   changes applied
	//
	//   - "Stop Reason EXPRESS_LICENSE_LIMITS_REACHED"
	//
	//   - "Stop Reason STOPPED_AFTER_DDL_APPLY" – User-defined stop task after DDL
	//   applied
	//
	//   - "Stop Reason STOPPED_DUE_TO_LOW_MEMORY"
	//
	//   - "Stop Reason STOPPED_DUE_TO_LOW_DISK"
	//
	//   - "Stop Reason STOPPED_AT_SERVER_TIME" – User-defined server time for stopping
	//   task
	//
	//   - "Stop Reason STOPPED_AT_COMMIT_TIME" – User-defined commit time for stopping
	//   task
	//
	//   - "Stop Reason RECONFIGURATION_RESTART"
	//
	//   - "Stop Reason RECYCLE_TASK"

Relations

Closes #43466

References

Output from Acceptance Testing

% make testacc TESTS=TestAccXXX PKG=ec2

...

Copy link
Contributor

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/dms Issues and PRs that pertain to the dms service. size/XS Managed by automation to categorize the size of a PR. external-maintainer Contribution from a trusted external contributor. labels Jul 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external-maintainer Contribution from a trusted external contributor. needs-triage Waiting for first response or review from a maintainer. service/dms Issues and PRs that pertain to the dms service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DMS Task is finished too fast for waiter
1 participant