Skip to content

Resource Identity: Passes Identity Spec to SDKv2 custom imports #43495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Jul 23, 2025
Merged

Resource Identity: Passes Identity Spec to SDKv2 custom imports #43495

merged 13 commits into from
Jul 23, 2025

Conversation

gdavison
Copy link
Contributor

@gdavison gdavison commented Jul 22, 2025 •
edited
Loading

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Description

Passes Identity Spec to SDKv2 custom imports rather than requiring developers to hardcode the Identity attributes in the custom import function.

Adds @CustomImport annotation

Builds on #43496

@gdavison gdavison requested a review from a team as a code owner July 22, 2025 17:37
@github-actions GitHub Actions
Copy link
Contributor

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/iam Issues and PRs that pertain to the iam service. service/s3 Issues and PRs that pertain to the s3 service. service/organizations Issues and PRs that pertain to the organizations service. service/batch Issues and PRs that pertain to the batch service. provider Pertains to the provider itself, rather than any interaction with AWS. service/acmpca Issues and PRs that pertain to the acmpca service. generators Relates to code generators. size/XL Managed by automation to categorize the size of a PR. labels Jul 22, 2025
@gdavison gdavison marked this pull request as draft July 22, 2025 17:38
@gdavison gdavison marked this pull request as ready for review July 23, 2025 05:25
ewbankkit
ewbankkit previously approved these changes Jul 23, 2025
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@gdavison gdavison dismissed ewbankkit’s stale review July 23, 2025 15:54

The merge-base changed after approval.

ewbankkit
ewbankkit previously approved these changes Jul 23, 2025
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@gdavison gdavison dismissed ewbankkit’s stale review July 23, 2025 16:01

The merge-base changed after approval.

@gdavison gdavison force-pushed the td-resource-identity-custom-import branch from 2cf7968 to 3c211ae Compare July 23, 2025 18:37
ewbankkit
ewbankkit approved these changes Jul 23, 2025
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@gdavison gdavison merged commit e2cfbd1 into main Jul 23, 2025
53 checks passed
@gdavison gdavison deleted the td-resource-identity-custom-import branch July 23, 2025 20:52
@github-actions GitHub Actions
Copy link
Contributor

Warning

This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v6.5.0 milestone Jul 23, 2025
@github-actions GitHub Actions
Copy link
Contributor

This functionality has been released in v6.5.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jul 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
generators Relates to code generators. provider Pertains to the provider itself, rather than any interaction with AWS. service/acmpca Issues and PRs that pertain to the acmpca service. service/batch Issues and PRs that pertain to the batch service. service/iam Issues and PRs that pertain to the iam service. service/organizations Issues and PRs that pertain to the organizations service. service/s3 Issues and PRs that pertain to the s3 service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v6.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@gdavison @ewbankkit