Handle 64bit on 32bit, broken builds

[YakDriver]

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Description

The build error occurred because validation.IntBetween(1, 4294967295) was trying to pass the literal 4294967295 (which equals 2^32- 1, the maximum 32-bit unsigned integer value) as an int parameter to the validation function. On 32-bit architectures, Go's int type is only 32 bits and has a maximum value of 2^31 - 1 (2147483647), so the literal 4294967295 overflows when used as an int argument. The fix creates a new IntBetween64 validation function that accepts int64 parameters instead of int parameters, allowing it to handle the full 32-bit ASN range (1-4294967295) without overflow issues. The function still validates int values from the schema, but internally converts them to int64 for range checking, maintaining backward compatibility while supporting the complete ASN value range on all architectures.

Relations

Problem introduced by #45246

References

Output from Acceptance Testing

% make testacc TESTS=TestAccXXX PKG=ec2

...

[github-actions]

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

• Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
• Please see our prioritization guide for additional information on how the maintainers handle prioritization.
• Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[YakDriver]

Couldn't find SDK int64 validator. If there is one, we could use that instead. But, one thing we know, validation.IntBetween(1, 4294967295) is DOA due to int arg.

[johnsonaj]

LGTM 🚀

[github-actions]

Warning

This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.