azurerm_cognitive_deployment - Supports DataZoneProvisionedManaged and GlobalProvisionedManaged in sku.name#28404
Merged
stephybun merged 3 commits intohashicorp:mainfrom Jan 8, 2025
Merged
Conversation
…pported sku names
stephybun
reviewed
Jan 7, 2025
| A `sku` block supports the following: | ||
|
|
||
| * `name` - (Required) The name of the SKU. Possible values include `Standard`, `DataZoneStandard`, `GlobalBatch`, `GlobalStandard` and `ProvisionedManaged`. | ||
| * `name` - (Required) The name of the SKU. Possible values include `Standard`, `DataZoneStandard`, `DataZoneProvisionedManaged`, `GlobalBatch`, `GlobalProvisionedManaged`, `GlobalStandard`, and `ProvisionedManaged`. |
Contributor
There was a problem hiding this comment.
Can you provide more info here on the special quote required for these SKUs?
Suggested change
| * `name` - (Required) The name of the SKU. Possible values include `Standard`, `DataZoneStandard`, `DataZoneProvisionedManaged`, `GlobalBatch`, `GlobalProvisionedManaged`, `GlobalStandard`, and `ProvisionedManaged`. | |
| * `name` - (Required) The name of the SKU. Possible values include `Standard`, `DataZoneStandard`, `DataZoneProvisionedManaged`, `GlobalBatch`, `GlobalProvisionedManaged`, `GlobalStandard`, and `ProvisionedManaged`. | |
| ~> **Note:** `DataZoneProvisionedManaged` and `GlobalProvisionedManaged` require ... [fill in special quota information here] ... |
Collaborator
Author
There was a problem hiding this comment.
I added all provisioned sku to the note and added a link to the onboarding link.
stephybun
approved these changes
Jan 8, 2025
Contributor
stephybun
left a comment
There was a problem hiding this comment.
Thanks @liuwuliuyun LGTM 👍
jackofallops
pushed a commit
that referenced
this pull request
Jan 10, 2025
jackofallops
added a commit
that referenced
this pull request
Jan 10, 2025
* Update CHANGELOG.md for #28233 * Update for #28215 * Update CHANGELOG.md for #28279 * Update CHANGELOG.md #28269 * Update CHANGELOG.md #27876 * Update CHANGELOG.md #28069 * Update CHANGELOG.md for #28312 * Update CHANGELOG.md for #28278 * Update CHANGELOG.md #28311 * Update CHANGELOG.md undo 28311 * Update CHANGELOG.md #27874 * Update CHANGELOG.md * Update CHANGELOG for #28352 * Update CHANGELOG.md for #28390 * Update CHANGELOG.md for #28398 * Update CHANGELOG.md for #28425 * Update CHANGELOG.md #28427 * Update CHANGELOG.md #28280 * Update CHANGELOG.md for #28319 * Update CHANGELOG.md #24801 * Update for #28360 #28216 #27830 #28404 #27401 #27122 #27931 #28442 * Update for #28379 * Update CHANGELOG.md for #28281 * Update for #28380 * Update for #27375 * Update for #25695 * Update CHANGELOG.md #27985 * Update CHANGELOG.md - update release date manually until can be scripted * Update CHANGELOG.md revert date change as script available * pre-release script updates --------- Co-authored-by: stephybun <steph@hashicorp.com> Co-authored-by: catriona-m <86247157+catriona-m@users.noreply.github.com> Co-authored-by: Wyatt Fry <wyattfry@gmail.com> Co-authored-by: sreallymatt <106555974+sreallymatt@users.noreply.github.com> Co-authored-by: Matthew Frahry <mbfrahry@gmail.com> Co-authored-by: kt <kt@katbyte.me>
NotTheEvilOne
pushed a commit
to b1-systems/terraform-provider-azurerm
that referenced
this pull request
Jan 20, 2025
…` and `GlobalProvisionedManaged` in `sku.name` (hashicorp#28404) * Add `DataZoneProvisionedManaged` and `GlobalProvisionedManaged` to supported sku names * Add explanation for provisioned skus based on review comment * Add explanation for provisioned skus based on review comment
NotTheEvilOne
pushed a commit
to b1-systems/terraform-provider-azurerm
that referenced
this pull request
Jan 20, 2025
* Update CHANGELOG.md for hashicorp#28233 * Update for hashicorp#28215 * Update CHANGELOG.md for hashicorp#28279 * Update CHANGELOG.md hashicorp#28269 * Update CHANGELOG.md hashicorp#27876 * Update CHANGELOG.md hashicorp#28069 * Update CHANGELOG.md for hashicorp#28312 * Update CHANGELOG.md for hashicorp#28278 * Update CHANGELOG.md hashicorp#28311 * Update CHANGELOG.md undo 28311 * Update CHANGELOG.md hashicorp#27874 * Update CHANGELOG.md * Update CHANGELOG for hashicorp#28352 * Update CHANGELOG.md for hashicorp#28390 * Update CHANGELOG.md for hashicorp#28398 * Update CHANGELOG.md for hashicorp#28425 * Update CHANGELOG.md hashicorp#28427 * Update CHANGELOG.md hashicorp#28280 * Update CHANGELOG.md for hashicorp#28319 * Update CHANGELOG.md hashicorp#24801 * Update for hashicorp#28360 hashicorp#28216 hashicorp#27830 hashicorp#28404 hashicorp#27401 hashicorp#27122 hashicorp#27931 hashicorp#28442 * Update for hashicorp#28379 * Update CHANGELOG.md for hashicorp#28281 * Update for hashicorp#28380 * Update for hashicorp#27375 * Update for hashicorp#25695 * Update CHANGELOG.md hashicorp#27985 * Update CHANGELOG.md - update release date manually until can be scripted * Update CHANGELOG.md revert date change as script available * pre-release script updates --------- Co-authored-by: stephybun <steph@hashicorp.com> Co-authored-by: catriona-m <86247157+catriona-m@users.noreply.github.com> Co-authored-by: Wyatt Fry <wyattfry@gmail.com> Co-authored-by: sreallymatt <106555974+sreallymatt@users.noreply.github.com> Co-authored-by: Matthew Frahry <mbfrahry@gmail.com> Co-authored-by: kt <kt@katbyte.me>
Contributor
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Community Note
Description
azurerm_cognitive_deployment- SupportsDataZoneProvisionedManagedandGlobalProvisionedManagedinsku.namePR Checklist
For example: “
resource_name_here- description of change e.g. adding propertynew_property_name_here”Changes to existing Resource / Data Source
Testing
The tests indicate that this change does not affect existing behavior. Additionally, the newly added SKU name requires a special quota and is expensive to run, so I did not include new tests for it.
Change Log
Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.
azurerm_cognitive_deployment- SupportsDataZoneProvisionedManagedandGlobalProvisionedManagedinsku.name[GH-28404]This is a (please select all that apply):
Related Issue(s)
Fixes #28392