Skip to content

Add Node.js 22 in function application_stack and Azure Web App application_stack#28081

Closed
wojtekmaj wants to merge 5 commits intohashicorp:mainfrom
wojtekmaj:function-node-22
Closed

Add Node.js 22 in function application_stack and Azure Web App application_stack#28081
wojtekmaj wants to merge 5 commits intohashicorp:mainfrom
wojtekmaj:function-node-22

Conversation

@wojtekmaj
Copy link
Copy Markdown

@wojtekmaj wojtekmaj commented Nov 21, 2024

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

On 10/24/2024, support for Node.js 22 in Azure Functions has been added as public preview.
Read more: https://azure.microsoft.com/en-us/updates?id=Azure-Functions-support-for-Nodejs-22

Note 1: This PR does not update Azure Web App application_stack, because it seems like Node.js 22 is not supported there yet.

Note 2: I have absolutely no idea what I'm doing, I tried to kinda sorta follow the changes from 7367b6e, with consideration for Note 1.

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here

Changes to existing Resource / Data Source

  • I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
  • I have written new tests for my resource or datasource changes & updated any relevent documentation.
  • I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
  • (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

  • My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

  • azurerm_resource - support for the thing1 property [GH-00000]

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Related Issue(s)

Fixes #0000

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

On 10/24/2024, support for Node.js 22 in Azure Functions has been added as public preview.
Read more: https://azure.microsoft.com/en-us/updates?id=Azure-Functions-support-for-Nodejs-22

Note 1: This PR does not update Azure Web App application_stack, because it seems like Node.js 22 is not supported there yet.

Note 2: I have absolutely no idea what I'm doing, I tried to kinda sorta follow the changes from 7367b6e, with consideration for Note 1.
DotNetVersion string `tfschema:"dotnet_version"` // Supported values `3.1`, `6.0`, `7.0`, `8.0` and `9.0`.
DotNetIsolated bool `tfschema:"use_dotnet_isolated_runtime"` // Supported values `true` for `dotnet-isolated`, `false` otherwise
NodeVersion string `tfschema:"node_version"` // Supported values `12LTS`, `14LTS`, `16LTS`, `18LTS, `20LTS``
NodeVersion string `tfschema:"node_version"` // Supported values `12LTS`, `14LTS`, `16LTS`, `18LTS, `20LTS`, `22LTS`
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will need to update the validation of this property in the actual schema to accept 22 as a value. If you search for func linuxFunctionAppStackSchema() in the provider you'll find the schema that corresponds to this model.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that has been tackled already in #28472.

DotNetVersion string `tfschema:"dotnet_version"` // Supported values `v3.0`, `v4.0`, `v6.0`, `v7.0`, `v8.0` and `v9.0`
DotNetIsolated bool `tfschema:"use_dotnet_isolated_runtime"` // Supported values `true` for `dotnet-isolated`, `false` otherwise
NodeVersion string `tfschema:"node_version"` // Supported values `12LTS`, `14LTS`, `16LTS`, `18LTS, `20LTS`
NodeVersion string `tfschema:"node_version"` // Supported values `12LTS`, `14LTS`, `16LTS`, `18LTS, `20LTS`, `22LTS`
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same for this, but looking for the windows schema equivalent.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed.

@southwolf
Copy link
Copy Markdown

@wojtekmaj I believe NodeJS 22 is now supported in Web App.
image

Copy link
Copy Markdown

@southwolf southwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe NodeJS 22 LTS is now available to Web App stack so it should also be added to

internal/services/appservice/helpers/app_stack.go

image

@github-actions github-actions bot added size/S and removed size/M labels Feb 6, 2025
@wojtekmaj
Copy link
Copy Markdown
Author

I believe NodeJS 22 LTS is now available to Web App stack so it should also be added to

internal/services/appservice/helpers/app_stack.go

image

Addressed.

@github-actions github-actions bot added size/XL and removed size/S labels Feb 6, 2025
@wojtekmaj wojtekmaj changed the title Add Node.js 22 in function application_stack Add Node.js 22 in function application_stack and Azure Web App application_stack Feb 6, 2025
@wojtekmaj wojtekmaj deleted the function-node-22 branch February 24, 2025 11:22
@github-actions
Copy link
Copy Markdown
Contributor

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants