Skip to content

[Enhancement:] azurerm_cdn_frontdoor_custom_domain - validate host_name values, refine ManagedCertificate hostname constraints, and harden related Front Door acceptance tests #32349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
WodansSon wants to merge 8 commits into
base: main
Choose a base branch
from
Open

[Enhancement:] azurerm_cdn_frontdoor_custom_domain - validate host_name values, refine ManagedCertificate hostname constraints, and harden related Front Door acceptance tests #32349

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
2ae145a
Refactor Front Door custom domain validation and update tests
WodansSon May 8, 2026
eb53743
Update accepted Cipher Suites for Tls12 and update tests....
WodansSon May 13, 2026
545d760
Refactor TLS validation and update documentation for ManagedCertificate
WodansSon May 15, 2026
ff4731f
Add preCheck method to CdnFrontDoorSecurityPolicyDataSource test
WodansSon May 15, 2026
ea99261
Skip tests if CDN is deprecated for creation
WodansSon May 15, 2026
33561e7
Add validation for wildcard domains in ManagedCertificate
WodansSon May 15, 2026
1ab41ef
Add unit test cases for invalid wildcard domain hostnames
WodansSon May 15, 2026
e5937a7
Update test host_name with a valid long string for CDN domain
WodansSon May 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions internal/services/cdn/azure_front_door_cache_purge_action_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ action "azurerm_cdn_front_door_cache_purge" "test" {
func (a *AzureFrontDoorCachePurgeAction) complete(data acceptance.TestData) string {
dnsZoneName := os.Getenv("ARM_TEST_DNS_ZONE")
dnsZoneRG := os.Getenv("ARM_TEST_DATA_RESOURCE_GROUP")
childZoneSuffix := data.RandomIntOfLength(8)
childZoneSuffix := data.RandomString
return fmt.Sprintf(`
provider "azurerm" {
features {}
Expand Down Expand Up @@ -138,7 +138,7 @@ data "azurerm_dns_zone" "test" {
locals {
# Create a delegated child zone inside the test RG.
# NOTE: ARM_TEST_DNS_ZONE / ARM_TEST_DATA_RESOURCE_GROUP must refer to a real, delegated parent zone.
child_zone_label = "acctest%[6]d"
child_zone_label = "%[6]s"
child_zone_name = join(".", [local.child_zone_label, data.azurerm_dns_zone.test.name])
}

Expand Down Expand Up @@ -207,5 +207,5 @@ action "azurerm_cdn_front_door_cache_purge" "test" {
]
}
}
`, data.RandomInteger, data.Locations.Primary, data.RandomString, dnsZoneName, dnsZoneRG, childZoneSuffix)
`, data.RandomInteger, data.Locations.Primary, "fd", dnsZoneName, dnsZoneRG, childZoneSuffix)
}
6 changes: 3 additions & 3 deletions internal/services/cdn/cdn_frontdoor_custom_domain_association_resource_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ func (r CdnFrontDoorCustomDomainAssociationResource) remove(data acceptance.Test
func (r CdnFrontDoorCustomDomainAssociationResource) template(data acceptance.TestData) string {
dnsZoneName := os.Getenv("ARM_TEST_DNS_ZONE")
dnsZoneRG := os.Getenv("ARM_TEST_DATA_RESOURCE_GROUP")
childZoneSuffix := data.RandomIntOfLength(8)
childZoneSuffix := data.RandomString
return fmt.Sprintf(`
provider "azurerm" {
features {}
Expand All @@ -184,7 +184,7 @@ data "azurerm_dns_zone" "test" {
locals {
# Create a delegated child zone inside the test RG.
# NOTE: ARM_TEST_DNS_ZONE / ARM_TEST_DATA_RESOURCE_GROUP must refer to a real, delegated parent zone.
child_zone_label = "acctest%[6]d"
child_zone_label = "%[6]s"
child_zone_name = join(".", [local.child_zone_label, data.azurerm_dns_zone.test.name])
}

Expand Down Expand Up @@ -288,7 +288,7 @@ resource "azurerm_cdn_frontdoor_custom_domain" "contoso" {
depends_on = [azurerm_dns_ns_record.delegation]

dns_zone_id = azurerm_dns_zone.child.id
host_name = join(".", ["%[3]s", azurerm_dns_zone.child.name])
host_name = join(".", ["fd", azurerm_dns_zone.child.name])

tls {
certificate_type = "ManagedCertificate"
Expand Down
Loading
Loading