Skip to content
This repository was archived by the owner on Dec 5, 2020. It is now read-only.

Update vendored Ignition to 0.34.0#63

Merged
alexsomesan merged 2 commits intohashicorp:masterfrom
LorbusChris:ign0.33.0
Dec 12, 2019
Merged

Update vendored Ignition to 0.34.0#63
alexsomesan merged 2 commits intohashicorp:masterfrom
LorbusChris:ign0.33.0

Conversation

@LorbusChris
Copy link
Copy Markdown
Contributor

@LorbusChris LorbusChris commented Dec 6, 2019

The version of Ignition that is currently vendored is outdated, this PR updates it.

Ignition 0.34.0 is the latest version supporting Spec version 2.x

@LorbusChris
Copy link
Copy Markdown
Contributor Author

cc @meyskens @alexsomesan

@LorbusChris LorbusChris changed the title Update vendored Ignition to 0.33.0 Update vendored Ignition to 0.34.0 Dec 12, 2019
@LorbusChris
Copy link
Copy Markdown
Contributor Author

Updated PR to use newly released Ignition 0.34.0

Copy link
Copy Markdown
Member

@alexsomesan alexsomesan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Test pass

~/workspace/terraform-provider-ignition(pr/LorbusChris/63) » make testacc                                                                                                                    alex@MacBook-Pro-2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v  -timeout 120m
?   	github.com/terraform-providers/terraform-provider-ignition	[no test files]
=== RUN   TestProvider
--- PASS: TestProvider (0.00s)
=== RUN   TestIgnitionFileReplace
--- PASS: TestIgnitionFileReplace (0.03s)
=== RUN   TestIgnitionFileAppend
--- PASS: TestIgnitionFileAppend (0.03s)
=== RUN   TestIgnitionFileReplaceNoVerification
--- PASS: TestIgnitionFileReplaceNoVerification (0.03s)
=== RUN   TestIgnitionFileAppendNoVerification
--- PASS: TestIgnitionFileAppendNoVerification (0.03s)
=== RUN   TestIgnitionConfigDisks
--- PASS: TestIgnitionConfigDisks (0.04s)
=== RUN   TestIgnitionConfigArrays
--- PASS: TestIgnitionConfigArrays (0.03s)
=== RUN   TestIgnitionConfigFilesystems
--- PASS: TestIgnitionConfigFilesystems (0.04s)
=== RUN   TestIgnitionConfigFiles
--- PASS: TestIgnitionConfigFiles (0.04s)
=== RUN   TestIgnitionConfigSystemd
--- PASS: TestIgnitionConfigSystemd (0.03s)
=== RUN   TestIgnitionConfigNetworkd
--- PASS: TestIgnitionConfigNetworkd (0.03s)
=== RUN   TestIgnitionConfigUsers
--- PASS: TestIgnitionConfigUsers (0.04s)
=== RUN   TestIgnitionConfigGroupss
--- PASS: TestIgnitionConfigGroupss (0.03s)
=== RUN   TestIgnitionDirectory
--- PASS: TestIgnitionDirectory (0.03s)
=== RUN   TestIgnitionDirectoryInvalidMode
--- PASS: TestIgnitionDirectoryInvalidMode (0.01s)
=== RUN   TestIgnitionDirectoryInvalidPath
--- PASS: TestIgnitionDirectoryInvalidPath (0.01s)
=== RUN   TestIgnitionDisk
--- PASS: TestIgnitionDisk (0.03s)
=== RUN   TestIgnitionDiskInvalidDevice
--- PASS: TestIgnitionDiskInvalidDevice (0.01s)
=== RUN   TestIgnitionDiskInvalidPartition
--- PASS: TestIgnitionDiskInvalidPartition (0.01s)
=== RUN   TestIgnitionFile
--- PASS: TestIgnitionFile (0.04s)
=== RUN   TestIgnitionFileInvalidMode
--- PASS: TestIgnitionFileInvalidMode (0.01s)
=== RUN   TestIgnitionFileInvalidPath
--- PASS: TestIgnitionFileInvalidPath (0.01s)
=== RUN   TestIgnitionFilesystem
--- PASS: TestIgnitionFilesystem (0.04s)
=== RUN   TestIgnitionFilesystemInvalidPath
--- PASS: TestIgnitionFilesystemInvalidPath (0.01s)
=== RUN   TestIgnitionFilesystemInvalidPathAndMount
--- PASS: TestIgnitionFilesystemInvalidPathAndMount (0.01s)
=== RUN   TestIgnitionGroup
--- PASS: TestIgnitionGroup (0.03s)
=== RUN   TestIgnitionLink
--- PASS: TestIgnitionLink (0.03s)
=== RUN   TestIgnitionLinkInvalidPath
--- PASS: TestIgnitionLinkInvalidPath (0.01s)
=== RUN   TestIgnitionNetworkdUnit
--- PASS: TestIgnitionNetworkdUnit (0.03s)
=== RUN   TestIgnitionRaid
--- PASS: TestIgnitionRaid (0.03s)
=== RUN   TestIgnitionRaidInvalidLevel
--- PASS: TestIgnitionRaidInvalidLevel (0.01s)
=== RUN   TestIgnitionRaidInvalidDevices
--- PASS: TestIgnitionRaidInvalidDevices (0.01s)
=== RUN   TestIgnitionSystemdUnit
--- PASS: TestIgnitionSystemdUnit (0.03s)
=== RUN   TestIgnitionSystemdUnitEmptyContentWithDropIn
--- PASS: TestIgnitionSystemdUnitEmptyContentWithDropIn (0.03s)
=== RUN   TestIgnitionSystemdUnit_emptyContent
--- PASS: TestIgnitionSystemdUnit_emptyContent (0.03s)
=== RUN   TestIgnitionSystemUnitInvalidName
--- PASS: TestIgnitionSystemUnitInvalidName (0.01s)
=== RUN   TestIgnitionSystemUnitInvalidContent
--- PASS: TestIgnitionSystemUnitInvalidContent (0.01s)
=== RUN   TestIgnitionUser
--- PASS: TestIgnitionUser (0.04s)
PASS
ok  	github.com/terraform-providers/terraform-provider-ignition/ignition	1.440s
------------------------------------------------------------
~/workspace/terraform-provider-ignition(pr/LorbusChris/63) » make test                                                                                                                       alex@MacBook-Pro-2
==> Checking that code complies with gofmt requirements...
go test -i $(go list ./... |grep -v 'vendor') || exit 1
echo $(go list ./... |grep -v 'vendor') | \
		xargs -t -n4 go test  -timeout=30s -parallel=4
go test -timeout=30s -parallel=4 github.com/terraform-providers/terraform-provider-ignition github.com/terraform-providers/terraform-provider-ignition/ignition
?   	github.com/terraform-providers/terraform-provider-ignition	[no test files]
ok  	github.com/terraform-providers/terraform-provider-ignition/ignition	1.307s
------------------------------------------------------------

@alexsomesan alexsomesan merged commit 704463f into hashicorp:master Dec 12, 2019
@LorbusChris
Copy link
Copy Markdown
Contributor Author

@alexsomesan thank you for cutting a new release as well!

@LorbusChris LorbusChris deleted the ign0.33.0 branch January 20, 2020 16:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants