-
Notifications
You must be signed in to change notification settings - Fork 1k
r/ingress_class - new resource #1236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
2171723
to
b050778
Compare
b1c1d7d
to
88e6495
Compare
any ETA when this might be ready ? watching the PR now for a while and waiting for a release :) 👍 |
Waiting for this as well. |
@DrFaust92 is there anything you know of that is blocking this PR to be merged ? can we maybe get a reviewers comment too please ! @dak1n1 @alexsomesan let me know if there is sth you could need help with to get this PR ready/merged ! |
@alexsomesan is there anything keeping this PR from being merged? |
Is there anything the community can do to drive this to be merged? |
@dak1n1 @alexsomesan @jrhouston pinging you as you have approved previous PRs and seem to be maintainers. could you pls shed some light how the community can get this PR merged ? |
@alexsomesan @dak1n1 @jrhouston Is there someone to call to get this one merged? |
@alexsomesan and @jrhouston I see you are active commiters so I yet again try to get your help on this PR: what would be missing to get this one merged ? |
c30bee7
to
9637523
Compare
Apologies for the delay here @philicious @lkishalmi @DrFaust92 – I have made a few fixes (some validation, docs fixes, and the resource ID didn't need to be namespaced) to this branch, and will merge once the the checks pass. |
thanks alot @jrhouston !!! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Acceptance tests
Output from acceptance testing:
Release Note
Release note for CHANGELOG:
References
Closes #1217
Closes #1218
Community Note