Skip to content

r/ingress_class - new resource #1236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Oct 4, 2021
Merged

Conversation

DrFaust92
Copy link
Contributor

@DrFaust92 DrFaust92 commented Apr 15, 2021

Description

Acceptance tests

  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccKubernetesIngressClass_'
--- PASS: TestAccKubernetesIngressClass_basic (2.98s)
--- PASS: TestAccKubernetesIngressClass_parameters (4.78s)
--- PASS: TestAccKubernetesIngressClass_parameters_apiGroup (4.82s)

Release Note

Release note for CHANGELOG:

resource_kubernetes_ingress_class - new resource

References

Closes #1217
Closes #1218

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@DrFaust92 DrFaust92 marked this pull request as ready for review April 16, 2021 10:17
@dak1n1 dak1n1 added the acknowledged Issue has undergone initial review and is in our work queue. label Apr 26, 2021
@philicious
Copy link

any ETA when this might be ready ? watching the PR now for a while and waiting for a release :) 👍

@lkishalmi
Copy link

Waiting for this as well.

@philicious
Copy link

@DrFaust92 is there anything you know of that is blocking this PR to be merged ?

can we maybe get a reviewers comment too please ! @dak1n1 @alexsomesan

let me know if there is sth you could need help with to get this PR ready/merged !

@lkishalmi
Copy link

@alexsomesan is there anything keeping this PR from being merged?

@nickbruun
Copy link

Is there anything the community can do to drive this to be merged?

@philicious
Copy link

@dak1n1 @alexsomesan @jrhouston pinging you as you have approved previous PRs and seem to be maintainers. could you pls shed some light how the community can get this PR merged ?

@lkishalmi
Copy link

@alexsomesan @dak1n1 @jrhouston Is there someone to call to get this one merged?

@philicious
Copy link

@alexsomesan and @jrhouston I see you are active commiters so I yet again try to get your help on this PR: what would be missing to get this one merged ?
its open for so long and becoming a a real bummer to not IngressClass supported by k8s provider yet 👎

@jrhouston
Copy link
Collaborator

Apologies for the delay here @philicious @lkishalmi @DrFaust92 – I have made a few fixes (some validation, docs fixes, and the resource ID didn't need to be namespaced) to this branch, and will merge once the the checks pass.

@jrhouston jrhouston merged commit f672c7e into hashicorp:main Oct 4, 2021
@philicious
Copy link

thanks alot @jrhouston !!!

@DrFaust92 DrFaust92 deleted the r/ingress_class branch October 5, 2021 13:06
@github-actions
Copy link

github-actions bot commented Nov 5, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
acknowledged Issue has undergone initial review and is in our work queue. documentation size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance kubernetes_ingress with ingress_class_name attribute Please provide a kubernetes_ingress_class resource
6 participants