Skip to content

Update 'Docker config' code example of kubernetes_secret(_v1) resource. #1626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 8, 2022

Conversation

arybolovlev
Copy link
Contributor

Description

This PR updates the 'Docker config' terraform code example of kubernetes_secret and kubernetes_secret_v1 resources.

Acceptance tests

  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

Release Note

Release note for CHANGELOG:

...

References

#1621

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@arybolovlev arybolovlev force-pushed the update-kubernetes-secret-documentation branch from f286f1f to e6b408d Compare March 7, 2022 13:18
Copy link
Member

@alexsomesan alexsomesan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Great job, @arybolovlev !

@arybolovlev arybolovlev merged commit 9b0e5f5 into main Mar 8, 2022
@arybolovlev arybolovlev deleted the update-kubernetes-secret-documentation branch March 8, 2022 09:29
@github-actions
Copy link

github-actions bot commented Apr 8, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kubernetes_secret resource doesn't yield the correct docker-registry secret with username and password
2 participants