fix: prevent duplicate set element error in project data source #1817
+11
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes Have you signed the CLA already but the status is still pending? Recheck it. |
lewis-catley
force-pushed
the
data-project-fix
branch
from
cb7d680 to
682f4b4
Compare
The GET /workspaces API call is ordered by run.created-at. It's possible that between retrieving the first page, and the next page that a workspace will appear on both pages. This then ultimately causes a 'Duplicate Set Element' error in the TF plan. This fix converts storing the API response as 2 lists to a single map, with the key being the workspace ID ensuring we overwrite any duplicates.
lewis-catley
force-pushed
the
data-project-fix
branch
from
682f4b4 to
eff0c51
Compare
|
Hey @lewis-catley, this PR has been re-created so we can have CI properly run against the changes: #1830 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The GET /workspaces API call is ordered by run.created-at. It's possible that between retrieving the first page, and the next page that a workspace will appear on both pages.
This then ultimately causes a 'Duplicate Set Element' error in the TF plan.
This fix converts storing the API response as 2 lists to a single map, with the key being the workspace ID ensuring we overwrite any duplicates.
Remember to:
Testing plan
External links
Include any links here that might be helpful for people reviewing your PR. If there are none, feel free to delete this section.
Output from acceptance tests
Please run applicable acceptance tests locally and include the output here. See testing.md to learn how to run acceptance tests.
If you are an external contributor, your contribution(s) will first be reviewed before running them against the project's CI pipeline.
Rollback Plan
Changes to Security Controls