terraform version: fix output order

[kmoe]

Running terraform version should output the version number, followed by the outdated message if any. This was broken in #25252 and the order was reversed. This PR fixes the order.

Expected behaviour

★ ./terraform version
Terraform v0.13.0-beta1

Your version of Terraform is out of date! The latest version
is 0.13.0. You can update by downloading from https://www.terraform.io/downloads.html

Actual behaviour

★ ./terraform version
Your version of Terraform is out of date! The latest version
is 0.13.0. You can update by downloading from https://www.terraform.io/downloads.html
Terraform v0.13.0-rc1

[codecov]

Codecov Report

Merging #25811 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted Files	Coverage Δ
command/version.go	66.66% <100.00%> (+12.23%)	⬆️
terraform/node_resource_plan.go	93.44% <0.00%> (+1.63%)	⬆️

[mildwonkey]

I'd like to see a test added for this, since the regression caused real issues. I haven't dug too deeply but it at a glance it appears that you can set a custom VersionCheckFunc for the version command, which (I would guess) would allow you to coerce the Outdated flag and specify the new version.

[kmoe]

Added test, which fails without 25337b7.

[mildwonkey]

Gorgeous, I love the tests - thanks @kmoe !

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.