Skip to content

terraform version: fix output order #25811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kmoe merged 2 commits into from
Aug 19, 2020
+64 −7
Merged

terraform version: fix output order #25811

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
25337b7
fix outdated message output order
kmoe Aug 11, 2020
e59553e
test outdated version output
kmoe Aug 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions command/version.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ Options:

func (c *VersionCommand) Run(args []string) int {
var outdated bool
var latest string
var versionString bytes.Buffer
args = c.Meta.process(args)
var jsonOutput bool
Expand Down Expand Up @@ -113,13 +114,7 @@ func (c *VersionCommand) Run(args []string) int {
}
if info.Outdated {
outdated = true
if !jsonOutput {
c.Ui.Output(fmt.Sprintf(
"\nYour version of Terraform is out of date! The latest version\n"+
"is %s. You can update by downloading from https://www.terraform.io/downloads.html",
info.Latest))
}

latest = info.Latest
}
}

Expand Down Expand Up @@ -159,6 +154,12 @@ func (c *VersionCommand) Run(args []string) int {
c.Ui.Output(str)
}
}
if outdated {
c.Ui.Output(fmt.Sprintf(
"\nYour version of Terraform is out of date! The latest version\n"+
"is %s. You can update by downloading from https://www.terraform.io/downloads.html",
latest))
}

}

Expand Down