Update create_before_destroy in state during refresh#26343
Merged
Conversation
Codecov Report
|
jbardin
force-pushed
the
jbardin/update-cbd-state
branch
2 times, most recently
from
3d6f869 to
83a79b7
Compare
Merged
mildwonkey
approved these changes
Sep 24, 2020
In order to save any changes to lifecycle options, we need to record those changes during refresh, otherwise they would only be updated when there is a change in the resource to be applied.
jbardin
force-pushed
the
jbardin/update-cbd-state
branch
from
83a79b7 to
a0cee10
Compare
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While
create_before_destroyis stored in the instance state, the status would only be updated when a change to the resource was applied. This meant that if a resource was incorrectly created with the wrong option, it would require a change to the resource itself to fix, which may not be possible with all resources.This change updates the stored
create_before_destroyvalue while the resource is being refreshed.Fixes #25473