handle null and unknown values in attr diffs#29410
Merged
Conversation
jbardin
added
the
1.0-backport
The code adopted from block diffs was not set to handle null and unknown values, as those are not allowed for blocks. We also revert the change to formatting nested object types as single attributes, because the attribute formatter cannot handle sensitive values from the schema. This presents some awkward syntax for diffs for now, but should suffice until the entire formatter can be refactored to better handle these new nested types.
jbardin
force-pushed
the
jbardin/format-empty-nested-attrs
branch
from
4c321ab to
68ed506
Compare
alisdair
approved these changes
Aug 18, 2021
Contributor
alisdair
left a comment
alisdair
left a comment
There was a problem hiding this comment.
This looks like a good compromise to me! I don't see any neat way to render empty collections on a single line without a big restructure, and the slightly less pretty diff doesn't feel like that big of a deal.
ghost
mentioned this pull request
Contributor
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code adopted from block diffs was not set to handle null and unknown
values, as those are not allowed for blocks. While there is much room for
improvement in the formatting code, this PR takes care to only update the
new code paths for formatting so as to not disturb the rather fragile existing
block formatting code.
We also revert the change to formatting nested object types as single
attributes, because the attribute formatter cannot handle sensitive
values from the schema. This presents some awkward syntax for diffs for
now, but should suffice until the entire formatter can be refactored to
better handle these new nested types.
Fixes #29392