Skip to content

Backport of handle null and unknown values in attr diffs into v1.0#29413

Closed
ghost wants to merge 1 commit intov1.0from
backport/jbardin/format-empty-nested-attrs/rightly-uncommon-bluegill
Closed

Backport of handle null and unknown values in attr diffs into v1.0#29413
ghost wants to merge 1 commit intov1.0from
backport/jbardin/format-empty-nested-attrs/rightly-uncommon-bluegill

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Aug 18, 2021

Backport

This PR is auto-generated from #29410 to be assessed for backporting due to the inclusion of the label 1.0-backport.

The below text is copied from the body of the original PR.


The code adopted from block diffs was not set to handle null and unknown
values, as those are not allowed for blocks. While there is much room for
improvement in the formatting code, this PR takes care to only update the
new code paths for formatting so as to not disturb the rather fragile existing
block formatting code.

We also revert the change to formatting nested object types as single
attributes, because the attribute formatter cannot handle sensitive
values from the schema. This presents some awkward syntax for diffs for
now, but should suffice until the entire formatter can be refactored to
better handle these new nested types.

Fixes #29392

@ghost ghost requested a review from jbardin August 18, 2021 18:54
@ghost ghost force-pushed the backport/jbardin/format-empty-nested-attrs/rightly-uncommon-bluegill branch from 8820440 to 63e4071 Compare August 18, 2021 18:54
@jbardin
Copy link
Copy Markdown
Member

jbardin commented Aug 18, 2021

requires manual backport

@jbardin jbardin closed this Aug 18, 2021
@github-actions
Copy link
Copy Markdown
Contributor

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant