Skip to content

cidrnetmask() produce an error with IPv6#30703

Merged
kmoe merged 3 commits intohashicorp:mainfrom
shinbunbun:fix-cidernetmask
Mar 25, 2022
Merged

cidrnetmask() produce an error with IPv6#30703
kmoe merged 3 commits intohashicorp:mainfrom
shinbunbun:fix-cidernetmask

Conversation

@shinbunbun
Copy link
Copy Markdown
Contributor

Make cidrnetmask() produce an error when trying to create a netmask for IPv6.

@hashicorp-cla
Copy link
Copy Markdown

hashicorp-cla commented Mar 19, 2022

CLA assistant check
All committers have signed the CLA.

@shinbunbun
Copy link
Copy Markdown
Contributor Author

@laurapacilio @kmoe

Hi, I have tried to solve this Issue.
If you don't mind, could you please review it?

@crw crw added the bug label Mar 21, 2022
@crw
Copy link
Copy Markdown
Contributor

crw commented Mar 21, 2022

Thanks for the submission!

Copy link
Copy Markdown
Member

@kmoe kmoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. Looks good. Error message could have a bit more context - see comment.

Co-authored-by: kmoe <5575356+kmoe@users.noreply.github.com>
@shinbunbun shinbunbun marked this pull request as ready for review March 24, 2022 15:28
@shinbunbun
Copy link
Copy Markdown
Contributor Author

@kmoe
Thank you for your review!
I accepted your suggestion.

@kmoe kmoe merged commit a1ead44 into hashicorp:main Mar 25, 2022
@github-actions
Copy link
Copy Markdown
Contributor

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

@github-actions
Copy link
Copy Markdown
Contributor

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cidrnetmask() should error with IPv6

4 participants