Conversation
|
I would prefer not to merge this because if we document that this function supports IPv6 addresses, even if not recommended, the current behavior will arguably become covered by the v1.0 compatibility promises and thus not correctable without a breaking change. Currently the incorrect behavior is covered under this statement:
My estimation is that this is not "likely to cause broad compatibility problems" because there is no real-world use to an IPv6 netmask and thus it should be pretty rare for a configuration to use one, and thus I think it's defensible to change Terraform to give better feedback when asked to produce a nonsensical result here. However, if we change the documentation to say that this function accepts IPv6 addresses then the above clause no longer applies. |
|
okay! works for me! :-) Thanks for the feedback! |
|
Could the function in question be fixed to actually throw an error for IPv6 addresses, since that's the issue that tripped me up? If I put in a PR for that change, would that be more likely to get traction? EDIT: Nevermind, ignore me. #30703 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Fix to prevent docs users from being confused until this issue is completed: #30680
This function does not actually produce an error if you use IPv6, even though it should. Rather than inaccurately saying it produces an error, we should make a statement to discourage users from using the function with IPv6.