Skip to content

Make the unknown attribute renderer consider the force replacement metadata#33065

Merged
liamcervante merged 1 commit intomainfrom
liamcervante/33041
Apr 24, 2023
Merged

Make the unknown attribute renderer consider the force replacement metadata#33065
liamcervante merged 1 commit intomainfrom
liamcervante/33041

Conversation

@liamcervante
Copy link
Copy Markdown
Contributor

This PR updates the unknown renderer to include the # force replacement suffix when necessary. I think that was missed initially as I couldn't think of any cases where a computed attribute would cause the replacement as something else would have to have triggered the attribute to be recomputed. As the issue demonstrates I think there is something happening within import commands that makes this assumption incorrect.

I've added tests into the renderer package to validate this, not much else needed as the data is already being made available it just wasn't being used.

Fixes #33041

Target Release

1.4.6

Draft CHANGELOG entry

BUG FIXES

  • Fixes bug where computed attributes were not being rendered with the # forces replacement suffix.

@liamcervante liamcervante added the 1.4-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged label Apr 21, 2023
@liamcervante liamcervante requested a review from a team April 21, 2023 07:23
@liamcervante liamcervante merged commit b54668f into main Apr 24, 2023
@liamcervante liamcervante deleted the liamcervante/33041 branch April 24, 2023 09:02
@github-actions
Copy link
Copy Markdown
Contributor

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

@github-actions
Copy link
Copy Markdown
Contributor

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

1.4-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

import docker container does not show 'forces replacement' for environment variables

2 participants