Make the unknown attribute renderer consider the force replacement metadata#33065
Merged
liamcervante merged 1 commit intomainfrom Apr 24, 2023
Merged
Make the unknown attribute renderer consider the force replacement metadata#33065liamcervante merged 1 commit intomainfrom
liamcervante merged 1 commit intomainfrom
Conversation
jbardin
approved these changes
Apr 21, 2023
Contributor
|
Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch. |
Contributor
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the unknown renderer to include the
# force replacementsuffix when necessary. I think that was missed initially as I couldn't think of any cases where a computed attribute would cause the replacement as something else would have to have triggered the attribute to be recomputed. As the issue demonstrates I think there is something happening withinimportcommands that makes this assumption incorrect.I've added tests into the renderer package to validate this, not much else needed as the data is already being made available it just wasn't being used.
Fixes #33041
Target Release
1.4.6
Draft CHANGELOG entry
BUG FIXES
# forces replacementsuffix.