Skip to content

Make the unknown attribute renderer consider the force replacement metadata #33065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
liamcervante merged 1 commit into from
Apr 24, 2023
Merged

Make the unknown attribute renderer consider the force replacement metadata #33065

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions internal/command/jsonformat/computed/renderers/renderer_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -408,6 +408,25 @@ jsonencode(
},
expected: "0 -> (known after apply)",
},
"computed_create_forces_replacement": {
diff: computed.Diff{
Renderer: Unknown(computed.Diff{}),
Action: plans.Create,
Replace: true,
},
expected: "(known after apply) # forces replacement",
},
"computed_update_forces_replacement": {
diff: computed.Diff{
Renderer: Unknown(computed.Diff{
Renderer: Primitive(0.0, nil, cty.Number),
Action: plans.Delete,
}),
Action: plans.Update,
Replace: true,
},
expected: "0 -> (known after apply) # forces replacement",
},
"object_created": {
diff: computed.Diff{
Renderer: Object(map[string]computed.Diff{}),
Expand Down
4 changes: 2 additions & 2 deletions internal/command/jsonformat/computed/renderers/unknown.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,10 @@ type unknownRenderer struct {

func (renderer unknownRenderer) RenderHuman(diff computed.Diff, indent int, opts computed.RenderHumanOpts) string {
if diff.Action == plans.Create {
return "(known after apply)"
return fmt.Sprintf("(known after apply)%s", forcesReplacement(diff.Replace, opts))
}

// Never render null suffix for children of unknown changes.
opts.OverrideNullSuffix = true
return fmt.Sprintf("%s -> (known after apply)", renderer.before.RenderHuman(indent, opts))
return fmt.Sprintf("%s -> (known after apply)%s", renderer.before.RenderHuman(indent, opts), forcesReplacement(diff.Replace, opts))
}