terraform 1.13.3 TERRAFORM CRASH

[TheRealMamuth]

Terraform Version

Terraform v1.13.3
on darwin_arm64
+ provider registry.terraform.io/hashicorp/aws v6.15.0
+ provider registry.terraform.io/hashicorp/random v3.7.2

Terraform Configuration Files

...terraform config...

Debug Output

Run terraform show -json ./downloaded-tfplan/tfplan > tfplan.json
  terraform show -json ./downloaded-tfplan/tfplan > tfplan.json
  shell: /usr/bin/bash -e {0}
  env:
    TERRAFORM_CLI_PATH: /home/runner/work/_temp/3813ca63-0ba4-4188-aece-cf4286b59396
!!!!!!!!!!!!!!!!!!!!!!!!!!! TERRAFORM CRASH !!!!!!!!!!!!!!!!!!!!!!!!!!!!
Terraform crashed! This is always indicative of a bug within Terraform.
Please report the crash with Terraform[1] so that we can fix this.
When reporting bugs, please include your terraform version, the stack trace
shown below, and any additional information which may help replicate the issue.
[1]: https://github.com/hashicorp/terraform/issues
!!!!!!!!!!!!!!!!!!!!!!!!!!! TERRAFORM CRASH !!!!!!!!!!!!!!!!!!!!!!!!!!!!
panic: runtime error: invalid memory address or nil pointer dereference
goroutine 1 [running]:
runtime/debug.Stack()
	runtime/debug/stack.go:26 +0x5e
github.com/hashicorp/terraform/internal/logging.PanicHandler()
	github.com/hashicorp/terraform/internal/logging/panic.go:84 +0x16a
panic({0x36a0fa0?, 0x6308e10?})
	runtime/panic.go:792 +0x132
github.com/hashicorp/terraform/internal/cloud.(*Cloud).AppName(...)
	github.com/hashicorp/terraform/internal/cloud/backend.go:440
github.com/hashicorp/terraform/internal/command.(*ShowCommand).getDataFromCloudPlan(0x7ffcd175fd1a?, 0xc000914db0, 0x0)
	github.com/hashicorp/terraform/internal/command/show.go:288 +0x155
github.com/hashicorp/terraform/internal/command.(*ShowCommand).getPlanFromPath(0xc000133880, {0x7ffcd175fd1a?, 0xc0002e7008?})
	github.com/hashicorp/terraform/internal/command/show.go:273 +0x75
github.com/hashicorp/terraform/internal/command.(*ShowCommand).showFromPath(0x2?, {0x7ffcd175fd1a, 0x1a})
	github.com/hashicorp/terraform/internal/command/show.go:189 +0x32
github.com/hashicorp/terraform/internal/command.(*ShowCommand).show(0xc000133880, {0x7ffcd175fd1a?, 0x2?})
	github.com/hashicorp/terraform/internal/command/show.go:132 +0x1a7
github.com/hashicorp/terraform/internal/command.(*ShowCommand).Run(0xc000133880, {0xc00012e0e0, 0x2, 0x2})
	github.com/hashicorp/terraform/internal/command/show.go:78 +0x3e5
github.com/hashicorp/cli.(*CLI).Run(0xc0008cef00)
	github.com/hashicorp/cli@v1.1.7/cli.go:265 +0x4de
main.realMain()
	github.com/hashicorp/terraform/main.go:339 +0x1deb
main.main()
	github.com/hashicorp/terraform/main.go:64 +0x13

Expected Behavior

generate tfplan.json

Actual Behavior

Run terraform show -json ./downloaded-tfplan/tfplan > tfplan.json
  terraform show -json ./downloaded-tfplan/tfplan > tfplan.json
  shell: /usr/bin/bash -e {0}
  env:
    TERRAFORM_CLI_PATH: /home/runner/work/_temp/3813ca63-0ba4-4188-aece-cf4286b59396
!!!!!!!!!!!!!!!!!!!!!!!!!!! TERRAFORM CRASH !!!!!!!!!!!!!!!!!!!!!!!!!!!!
Terraform crashed! This is always indicative of a bug within Terraform.
Please report the crash with Terraform[1] so that we can fix this.
When reporting bugs, please include your terraform version, the stack trace
shown below, and any additional information which may help replicate the issue.
[1]: https://github.com/hashicorp/terraform/issues
!!!!!!!!!!!!!!!!!!!!!!!!!!! TERRAFORM CRASH !!!!!!!!!!!!!!!!!!!!!!!!!!!!
panic: runtime error: invalid memory address or nil pointer dereference
goroutine 1 [running]:
runtime/debug.Stack()
	runtime/debug/stack.go:26 +0x5e
github.com/hashicorp/terraform/internal/logging.PanicHandler()
	github.com/hashicorp/terraform/internal/logging/panic.go:84 +0x16a
panic({0x36a0fa0?, 0x6308e10?})
	runtime/panic.go:792 +0x132
github.com/hashicorp/terraform/internal/cloud.(*Cloud).AppName(...)
	github.com/hashicorp/terraform/internal/cloud/backend.go:440
github.com/hashicorp/terraform/internal/command.(*ShowCommand).getDataFromCloudPlan(0x7ffcd175fd1a?, 0xc000914db0, 0x0)
	github.com/hashicorp/terraform/internal/command/show.go:288 +0x155
github.com/hashicorp/terraform/internal/command.(*ShowCommand).getPlanFromPath(0xc000133880, {0x7ffcd175fd1a?, 0xc0002e7008?})
	github.com/hashicorp/terraform/internal/command/show.go:273 +0x75
github.com/hashicorp/terraform/internal/command.(*ShowCommand).showFromPath(0x2?, {0x7ffcd175fd1a, 0x1a})
	github.com/hashicorp/terraform/internal/command/show.go:189 +0x32
github.com/hashicorp/terraform/internal/command.(*ShowCommand).show(0xc000133880, {0x7ffcd175fd1a?, 0x2?})
	github.com/hashicorp/terraform/internal/command/show.go:132 +0x1a7
github.com/hashicorp/terraform/internal/command.(*ShowCommand).Run(0xc000133880, {0xc00012e0e0, 0x2, 0x2})
	github.com/hashicorp/terraform/internal/command/show.go:78 +0x3e5
github.com/hashicorp/cli.(*CLI).Run(0xc0008cef00)
	github.com/hashicorp/cli@v1.1.7/cli.go:265 +0x4de
main.realMain()
	github.com/hashicorp/terraform/main.go:339 +0x1deb
main.main()
	github.com/hashicorp/terraform/main.go:64 +0x13

Steps to Reproduce

tf-summarize:
runs-on: ubuntu-latest
if: github.ref == 'refs/heads/main'
needs: [tf-plan]

steps:
  - name: Download tfplan
    uses: actions/download-artifact@v5
    with:
      name: tfplan
      path: ./downloaded-tfplan

  - uses: hashicorp/setup-terraform@v3
    with:
      terraform_version: 1.13.3
      cli_config_credentials_token: ${{ secrets.TF_API_TOKEN }}

  - name: Terraform init
    id: init
    run: terraform init -input=false -backend=false

  - name: Terraform show
    id: show
    run: |
      terraform show -json ./downloaded-tfplan/tfplan > tfplan.json

Additional Context

No response

References

No response

Generative AI / LLM assisted development?

No response

[dbanck]

Thanks for the report! I was able to reproduce the bug and fix the crash.

Instead of crashing Terraform will now show a diagnostic (this has been the behavior before the crash):

❯ terraform show -json tfplan
╷
│ Error: Couldn't show cloud plan
│
│ Plan read error: can't show a saved cloud plan unless the current root module is connected to HCP Terraform
╵
Unable to parse input: "Unexpected EOF"

I assume this is still not what you are trying to achieve in your CI pipeline?

[TheRealMamuth]

Thanks for the report! I was able to reproduce the bug and fix the crash.

Instead of crashing Terraform will now show a diagnostic (this has been the behavior before the crash):

❯ terraform show -json tfplan
╷
│ Error: Couldn't show cloud plan
│
│ Plan read error: can't show a saved cloud plan unless the current root module is connected to HCP Terraform
╵
Unable to parse input: "Unexpected EOF"

I assume this is still not what you are trying to achieve in your CI pipeline?

Hi:

my full github actions:

name: "Terraform Plan and Apply"

on:
  workflow_dispatch:

jobs:
  # This job validates the Terraform configuration files. ============================================================
  tf-validate:
    runs-on: ubuntu-latest
    if: github.event_name == 'workflow_dispatch'
    steps:
      - uses: actions/checkout@v5

      - uses: hashicorp/setup-terraform@v3
        with:
          terraform_version: 1.13
          cli_config_credentials_token: ${{ secrets.TF_API_TOKEN }}

      - name: Terraform init
        id: init
        run: terraform init -input=false

      - name: Terraform validate
        id: validate
        run: terraform validate
  
  # This job checks the formatting of the Terraform configuration files. =================================================
  tf-fmt:
    runs-on: ubuntu-latest
    if: github.event_name == 'workflow_dispatch'
    steps:
      - uses: actions/checkout@v5

      - uses: hashicorp/setup-terraform@v3
        with:
          terraform_version: 1.13

      - name: Terraform fmt
        id: fmt
        run: terraform fmt -check -recursive

  tf-plan:
    runs-on: ubuntu-latest
    if: github.event_name == 'workflow_dispatch'
    needs: tf-validate

    outputs:
      tfplanExitCode: S{{ steps.tf-plan.outputs.exitcode }}

    steps:
      - uses: actions/checkout@v5

      - uses: hashicorp/setup-terraform@v3
        with:
          terraform_version: 1.13
          cli_config_credentials_token: ${{ secrets.TF_API_TOKEN }}

      - name: Configure variable file
        run: |
          cat << EOF > ./.auto.tfvars
          ${{ secrets.VAR_TFVARS }}
          EOF

      - name: Terraform init
        id: init
        run: terraform init -input=false

      - name: Terraform plan 
        id: only_plan
        if: github.ref != 'refs/heads/main'
        run: |
          terraform plan \
          -out=tfplan \
          -input=false

      - name: Terraform plan with tfplan output
        id: plan
        if: github.ref == 'refs/heads/main'
        run: |
          export exitcode=0
          terraform plan \
          -detailed-exitcode \
          -out=tfplan \
          -input=false || export exitcode=$?

          echo "exitcode=$exitcode" >> $GITHUB_OUTPUT

          if [ $exitcode -eq 1 ]; then
            echo "Plan failed"
            exit 1
          else
            echo "Plan succeeded"
            exit 0
          fi

      - name: Upload tfplan
        if: github.ref == 'refs/heads/main'
        uses: actions/upload-artifact@v4
        with:
          name: tfplan
          path: tfplan
  
  tf-summarize:
    runs-on: ubuntu-latest
    if: github.ref == 'refs/heads/main'
    needs: [tf-plan]

    steps:
      - name: Download tfplan
        uses: actions/download-artifact@v5
        with:
          name: tfplan
          path: ./downloaded-tfplan

      - uses: hashicorp/setup-terraform@v3
        with:
          terraform_version: 1.13.3
          cli_config_credentials_token: ${{ secrets.TF_API_TOKEN }}

      - name: Terraform init
        id: init
        run: terraform init -input=false -backend=false

      - name: Copy plan
        id: show
        run: |
          terraform show -json ./downloaded-tfplan/tfplan > tfplan.json

      - name: Install Docker
        uses: docker/setup-buildx-action@v3

      - name: Visualize Terraform plan
        id: visualize
        run: |
          echo ""
          echo "############################"
          echo "###  TREE FORMAT - PLAN  ###"
          echo "############################"
          echo ""
          docker run -v $PWD:/workspace -w /workspace ghcr.io/dineshba/tf-summarize -tree tfplan.json

          # summary in separate tree format
          echo ""
          echo "###############################"
          echo "###  TREE S FORMAT - PLAN   ###"
          echo "###############################"
          echo ""
          docker run -v $PWD:/workspace -w /workspace ghcr.io/dineshba/tf-summarize -separate-tree tfplan.json
  
  tf-apply:
    runs-on: ubuntu-latest
    if: github.ref == 'refs/heads/main'
    needs: [tf-plan]

    steps:
      - uses: actions/checkout@v4

      - uses: hashicorp/setup-terraform@v3
        with:
          terraform_version: 1.13
          cli_config_credentials_token: ${{ secrets.TF_API_TOKEN }}

      - name: Terraform init
        id: init
        run: terraform init -input=false

      - name: Download tfplan
        uses: actions/download-artifact@v5
        with:
          name: tfplan
          path: ./downloaded-tfplan

      - name: Terraform apply
        id: apply
        run: |
          terraform apply ./downloaded-tfplan/tfplan

  tf-output:
    runs-on: ubuntu-latest
    if: github.ref == 'refs/heads/main'
    needs: [tf-apply]

    steps:
      - uses: actions/checkout@v5

      - uses: hashicorp/setup-terraform@v3
        with:
          terraform_version: 1.13
          cli_config_credentials_token: ${{ secrets.TF_API_TOKEN }}

      - name: Terraform init
        id: init
        run: terraform init -input=false

      - name: Terraform output
        id: output
        run: terraform output

  discord_error_message:
    runs-on: ubuntu-latest
    needs: [tf-validate, tf-fmt, tf-plan, tf-apply, tf-output]
    if: ${{ always() && contains(needs.*.result, 'failure') }}
    steps:
      - name: Identify failed job
        id: identify_failed_job
        run: |
          failed_jobs=()
          if [ "${{ needs.tf-validate.result }}" == "failure" ]; then
            failed_jobs+=("tf-validate")
          fi
          if [ "${{ needs.tf-fmt.result }}" == "failure" ]; then
            failed_jobs+=("tf-fmt")
          fi
          if [ "${{ needs.tf-plan.result }}" == "failure" ]; then
            failed_jobs+=("tf-plan")
          fi
          if [ "${{ needs.tf-apply.result }}" == "failure" ]; then
            failed_jobs+=("tf-apply")
          fi
          if [ "${{ needs.tf-output.result }}" == "failure" ]; then
            failed_jobs+=("tf-output")
          fi
          echo "failed_jobs=${failed_jobs[@]}" >> $GITHUB_ENV

      - name: Send Discord notification
        uses: tsickert/discord-webhook@v5.3.0
        with:
          webhook-url: ${{ secrets.WEBHOOK_URL_DISCORD }}
          content: |
            **PROBLEM:** There was a problem with the Terraform workflow:
            - **Repository:** ${{ github.repository }}
            - **Branch:** ${{ github.ref }}
            - **Action:** ${{ github.event_name }}
            - **Workflow:** ${{ github.workflow }}
            - **Failed Jobs:** ${{ env.failed_jobs }}
            - **Run ID:** ${{ github.run_id }}
            - **Run Number:** ${{ github.run_number }}
            - **Commit:** ${{ github.sha }}

and i get error to do this:

Run terraform show -json ./downloaded-tfplan/tfplan > tfplan.json
  terraform show -json ./downloaded-tfplan/tfplan > tfplan.json
  shell: /usr/bin/bash -e {0}
  env:
    TERRAFORM_CLI_PATH: /home/runner/work/_temp/3813ca63-0ba4-4188-aece-cf4286b59396
!!!!!!!!!!!!!!!!!!!!!!!!!!! TERRAFORM CRASH !!!!!!!!!!!!!!!!!!!!!!!!!!!!
Terraform crashed! This is always indicative of a bug within Terraform.
Please report the crash with Terraform[1] so that we can fix this.
When reporting bugs, please include your terraform version, the stack trace
shown below, and any additional information which may help replicate the issue.
[1]: https://github.com/hashicorp/terraform/issues
!!!!!!!!!!!!!!!!!!!!!!!!!!! TERRAFORM CRASH !!!!!!!!!!!!!!!!!!!!!!!!!!!!
panic: runtime error: invalid memory address or nil pointer dereference
goroutine 1 [running]:
runtime/debug.Stack()
	runtime/debug/stack.go:26 +0x5e
github.com/hashicorp/terraform/internal/logging.PanicHandler()
	github.com/hashicorp/terraform/internal/logging/panic.go:84 +0x16a
panic({0x36a0fa0?, 0x6308e10?})
	runtime/panic.go:792 +0x132
github.com/hashicorp/terraform/internal/cloud.(*Cloud).AppName(...)
	github.com/hashicorp/terraform/internal/cloud/backend.go:440
github.com/hashicorp/terraform/internal/command.(*ShowCommand).getDataFromCloudPlan(0x7ffcd175fd1a?, 0xc000914db0, 0x0)
	github.com/hashicorp/terraform/internal/command/show.go:288 +0x155
github.com/hashicorp/terraform/internal/command.(*ShowCommand).getPlanFromPath(0xc000133880, {0x7ffcd175fd1a?, 0xc0002e7008?})
	github.com/hashicorp/terraform/internal/command/show.go:273 +0x75
github.com/hashicorp/terraform/internal/command.(*ShowCommand).showFromPath(0x2?, {0x7ffcd175fd1a, 0x1a})
	github.com/hashicorp/terraform/internal/command/show.go:189 +0x32
github.com/hashicorp/terraform/internal/command.(*ShowCommand).show(0xc000133880, {0x7ffcd175fd1a?, 0x2?})
	github.com/hashicorp/terraform/internal/command/show.go:132 +0x1a7
github.com/hashicorp/terraform/internal/command.(*ShowCommand).Run(0xc000133880, {0xc00012e0e0, 0x2, 0x2})
	github.com/hashicorp/terraform/internal/command/show.go:78 +0x3e5
github.com/hashicorp/cli.(*CLI).Run(0xc0008cef00)
	github.com/hashicorp/cli@v1.1.7/cli.go:265 +0x4de
main.realMain()
	github.com/hashicorp/terraform/main.go:339 +0x1deb
main.main()
	github.com/hashicorp/terraform/main.go:64 +0x13

Yes - my case is to generate tfplan.jseon and use them in conteiner

[TheRealMamuth]

But - I don't have this error / crush on my local computer only in github actions

[dbanck]

I see that you are setting the cli_config_credentials_token for the hashicorp/setup-terraform action. I therefore assume that you are running your Terraform operations in HCP Terraform.

In that case, the terraform plan -out=tfplan command will produce a cloud plan (file). In order to view this file, you need a cloud backend. However, in your tf-summarize step, you are passing -backend=false to terraform init which disables the HCP Terraform initialization, so Terraform can't show the plan.

[TheRealMamuth]

I see that you are setting the cli_config_credentials_token for the hashicorp/setup-terraform action. I therefore assume that you are running your Terraform operations in HCP Terraform.

In that case, the terraform plan -out=tfplan command will produce a cloud plan (file). In order to view this file, you need a cloud backend. However, in your tf-summarize step, you are passing -backend=false to terraform init which disables the HCP Terraform initialization, so Terraform can't show the plan.

if I use terraform init

i have same crash

 tf-summarize:
    runs-on: ubuntu-latest
    if: github.ref == 'refs/heads/main'
    needs: [tf-plan]

    steps:
      - name: Download tfplan
        uses: actions/download-artifact@v5
        with:
          name: tfplan
          path: ./downloaded-tfplan

      - uses: hashicorp/setup-terraform@v3
        with:
          terraform_version: 1.13.3
          cli_config_credentials_token: ${{ secrets.TF_API_TOKEN }}

      - name: Terraform init
        id: init
        run: terraform init -input=false

      - name: Convert to JSON
        id: show
        run: |
          terraform show -json ./downloaded-tfplan/tfplan > tfplan.json

      - name: Install Docker
        uses: docker/setup-buildx-action@v3

      - name: Visualize Terraform plan
        id: visualize
        run: |
          echo ""
          echo "############################"
          echo "###  TREE FORMAT - PLAN  ###"
          echo "############################"
          echo ""
          docker run -v $PWD:/workspace -w /workspace ghcr.io/dineshba/tf-summarize -tree tfplan.json

          # summary in separate tree format
          echo ""
          echo "###############################"
          echo "###  TREE S FORMAT - PLAN   ###"
          echo "###############################"
          echo ""
          docker run -v $PWD:/workspace -w /workspace ghcr.io/dineshba/tf-summarize -separate-tree tfplan.json

Run terraform show -json ./downloaded-tfplan/tfplan > tfplan.json
terraform show -json ./downloaded-tfplan/tfplan > tfplan.json
shell: /usr/bin/bash -e {0}
env:
TERRAFORM_CLI_PATH: /home/runner/work/_temp/ab424558-abb9-4fd1-ab7e-8d0ef89748dd

!!!!!!!!!!!!!!!!!!!!!!!!!!! TERRAFORM CRASH !!!!!!!!!!!!!!!!!!!!!!!!!!!!
Terraform crashed! This is always indicative of a bug within Terraform.
Please report the crash with Terraform[1] so that we can fix this.
When reporting bugs, please include your terraform version, the stack trace
shown below, and any additional information which may help replicate the issue.
[1]: https://github.com/hashicorp/terraform/issues
!!!!!!!!!!!!!!!!!!!!!!!!!!! TERRAFORM CRASH !!!!!!!!!!!!!!!!!!!!!!!!!!!!
panic: runtime error: invalid memory address or nil pointer dereference
goroutine 1 [running]:
runtime/debug.Stack()
runtime/debug/stack.go:26 +0x5e
github.com/hashicorp/terraform/internal/logging.PanicHandler()
github.com/hashicorp/terraform/internal/logging/panic.go:84 +0x16a
panic({0x36a0fa0?, 0x6308e10?})
runtime/panic.go:792 +0x132
github.com/hashicorp/terraform/internal/cloud.(*Cloud).AppName(...)
github.com/hashicorp/terraform/internal/cloud/backend.go:440
github.com/hashicorp/terraform/internal/command.(*ShowCommand).getDataFromCloudPlan(0x7ffecbbf8d1a?, 0xc00063db90, 0x0)
github.com/hashicorp/terraform/internal/command/show.go:288 +0x155
github.com/hashicorp/terraform/internal/command.(*ShowCommand).getPlanFromPath(0xc00064a1c0, {0x7ffecbbf8d1a?, 0xc000760008?})
github.com/hashicorp/terraform/internal/command/show.go:273 +0x75
github.com/hashicorp/terraform/internal/command.(*ShowCommand).showFromPath(0x2?, {0x7ffecbbf8d1a, 0x1a})
github.com/hashicorp/terraform/internal/command/show.go:189 +0x32
github.com/hashicorp/terraform/internal/command.(*ShowCommand).show(0xc00064a1c0, {0x7ffecbbf8d1a?, 0x2?})
github.com/hashicorp/terraform/internal/command/show.go:132 +0x1a7
github.com/hashicorp/terraform/internal/command.(*ShowCommand).Run(0xc00064a1c0, {0xc000070120, 0x2, 0x2})
github.com/hashicorp/terraform/internal/command/show.go:78 +0x3e5
github.com/hashicorp/cli.(*CLI).Run(0xc00064c280)
github.com/hashicorp/cli@v1.1.7/cli.go:265 +0x4de
main.realMain()
github.com/hashicorp/terraform/main.go:339 +0x1deb
main.main()
github.com/hashicorp/terraform/main.go:64 +0x13
Error: Process completed with exit code 1.

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.