Skip to content

Fix crash when showing a cloud plan without having a cloud backend#37751

Merged
dbanck merged 2 commits intomainfrom
dbanck/fix-show-crash
Oct 10, 2025
Merged

Fix crash when showing a cloud plan without having a cloud backend#37751
dbanck merged 2 commits intomainfrom
dbanck/fix-show-crash

Conversation

@dbanck
Copy link
Copy Markdown
Member

@dbanck dbanck commented Oct 9, 2025

This PR fixes a crash when trying to view a cloud plan without having a cloud backend configured. The crash is a regression of the rebrand Terraform Cloud to HCP Terraform where a AppName() method was introduced to improve Terraform Enterprise support.

Fixes #37748

Target Release

1.13.x

Rollback Plan

  • If a change needs to be reverted, we will roll out an update to the code within 7 days.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

CHANGELOG entry

  • This change is user-facing and I added a changelog entry.
  • This change is not user-facing.

@dbanck dbanck requested a review from a team as a code owner October 9, 2025 12:46
@dbanck dbanck added the 1.13-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged label Oct 9, 2025
@dbanck dbanck requested a review from a team as a code owner October 9, 2025 12:46
@dbanck dbanck added the 1.14-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged label Oct 9, 2025
SarahFrench
SarahFrench approved these changes Oct 9, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@SarahFrench SarahFrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me!

@dbanck dbanck merged commit cc30a8c into main Oct 10, 2025
7 checks passed
@dbanck dbanck deleted the dbanck/fix-show-crash branch October 10, 2025 08:51
This was referenced Oct 10, 2025
Closed
Merged
dbanck added a commit that referenced this pull request Oct 10, 2025
@dbanck
Fix crash when showing a cloud plan without having a cloud backend (#…
c7c866a 
…37751)

* Fix crash when showing a cloud plan without a cloud backend

* Add changelog
@dbanck dbanck mentioned this pull request Oct 10, 2025
Merged
3 tasks
dbanck added a commit that referenced this pull request Oct 10, 2025
@dbanck
Fix crash when showing a cloud plan without having a cloud backend (#…
17337e7 
…37751) (#37757)

* Fix crash when showing a cloud plan without a cloud backend

* Add changelog
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 10, 2025

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@DanielMSchmidt DanielMSchmidt DanielMSchmidt approved these changes

@SarahFrench SarahFrench SarahFrench approved these changes

Assignees

No one assigned

Labels

1.13-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged 1.14-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

terraform 1.13.3 TERRAFORM CRASH

3 participants

@dbanck @DanielMSchmidt @SarahFrench