providers lock: include test files when loading configuration#37851
Merged
providers lock: include test files when loading configuration#37851
Conversation
dsa0x
approved these changes
Nov 3, 2025
Member
dsa0x
left a comment
There was a problem hiding this comment.
I do think it makes more sense to backport this into 1.14. Besides being a bug or not, the additional flag could also be seen as an enhancement, and that is okay to go into a patch version.
Contributor
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the
providers lockcommand so that it also includes providers embedded in Terraform test modules. This makesproviders lockmatch the behaviour ofinitin terms of provider discovery, and makes sense to me in terms of discovering provider requirements.I've marked this as a backport into 1.14.1 as I do think it is fixing a bug, but it does also necessarily introduce a new flag to providers lock so maybe that's enough to mean this should be delayed to 1.15.0. I'm happy to take that feedback if people think so.
Fixes #37841
Target Release
1.14.1
Rollback Plan
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
CHANGELOG entry