Skip to content

providers lock: include test files when loading configuration#37851

Merged
dsa0x merged 1 commit intomainfrom
liamcervante/37841
Nov 17, 2025
Merged

providers lock: include test files when loading configuration#37851
dsa0x merged 1 commit intomainfrom
liamcervante/37841

Conversation

@liamcervante
Copy link
Copy Markdown
Contributor

This PR updates the providers lock command so that it also includes providers embedded in Terraform test modules. This makes providers lock match the behaviour of init in terms of provider discovery, and makes sense to me in terms of discovering provider requirements.

I've marked this as a backport into 1.14.1 as I do think it is fixing a bug, but it does also necessarily introduce a new flag to providers lock so maybe that's enough to mean this should be delayed to 1.15.0. I'm happy to take that feedback if people think so.

Fixes #37841

Target Release

1.14.1

Rollback Plan

  • If a change needs to be reverted, we will roll out an update to the code within 7 days.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

CHANGELOG entry

  • This change is user-facing and I added a changelog entry.
  • This change is not user-facing.

@liamcervante liamcervante requested a review from a team as a code owner October 31, 2025 13:53
@liamcervante liamcervante added the 1.14-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged label Oct 31, 2025
Copy link
Copy Markdown
Member

@dsa0x dsa0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do think it makes more sense to backport this into 1.14. Besides being a bug or not, the additional flag could also be seen as an enhancement, and that is okay to go into a patch version.

@dsa0x dsa0x merged commit cfbfdc5 into main Nov 17, 2025
12 of 13 checks passed
@dsa0x dsa0x deleted the liamcervante/37841 branch November 17, 2025 07:33
@github-actions
Copy link
Copy Markdown
Contributor

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

1.14-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"terraform providers lock" does not lock providers required by tests

2 participants