lang/funcs: add "abspath" function

[AndiDog]

Allows working around #21400, and covers a suggested function in #16697

[hashicorp-cla]

All committers have signed the CLA.

[mildwonkey]

Hi @AndiDog, thank you for submitting this!

The test failure is due to the new abspath function missing from this test: https://github.com/hashicorp/terraform/blob/master/lang/functions_test.go
Can you add the function to that?

Now that I look at this error in travis, I will see about making the message clearer and more actionable.

[AndiDog]

The error is crystal clear, thanks. I simply didn't run a full make test because I had peaked at a similar commit and thought my newly added test would be enough to pass the complete suite. Adding the missing test in a moment.

[apparentlymart]

Thanks for working on this, @AndiDog!

I left one minor comment inline, motivated by consistency with how the path. references behave in 0.12. If you don't have time to respond to that with a code change, please do let me know and we'll be happy to adjust it as part of merging, since it's a relatively small change and easy to test.

[AndiDog]

@apparentlymart Ready for your review

[AndiDog]

Can we get this in? Still merges nicely to master and the change is very simple.

[peimanja]

Any update on this one?

[mildwonkey]

@AndiDog thanks for submitting this and addressing the feedback, I'll get this merged 🎉 🎉 🎉

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.