Fix panic on invalid depends_on root.#21589
Merged
mildwonkey merged 1 commit intohashicorp:masterfrom Jun 6, 2019
k0ffee:fix/crash-on-invalid-depends_on
Merged
Fix panic on invalid depends_on root.#21589mildwonkey merged 1 commit intohashicorp:masterfrom k0ffee:fix/crash-on-invalid-depends_on
mildwonkey merged 1 commit intohashicorp:masterfrom
k0ffee:fix/crash-on-invalid-depends_on
Conversation
|
|
ghost
mentioned this pull request
pselle
reviewed
Jun 5, 2019
Contributor
pselle
left a comment
pselle
left a comment
There was a problem hiding this comment.
Looking good! One question/nit
Contributor
|
Thanks for working on this @tinocode ! I'm going to dig a little deeper into this issue - from my understanding, there should always be an error if |
mildwonkey
reviewed
Jun 5, 2019
mildwonkey
requested changes
Jun 5, 2019
Assume "ref" can be nil and report an invalid reference to the user instead of crashing.
Contributor
|
Great, thank you so much @tinocode! 🎉 |
mildwonkey
approved these changes
Jun 6, 2019
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assume "ref" can be nil and report an invalid reference to
the user instead of crashing.
This is a regression from terraform 0.11 and now fails in 0.12.0.
Including test case.