vendor: go get github.com/zclconf/go-cty@v1.4.0#24621
Merged
vendor: go get github.com/zclconf/go-cty@v1.4.0#24621
Conversation
This fixes several bugs:
- `substr("abc", 0, 0)` would previously return `"abc"`, despite the
length argument being `0`. This has been changed to return an empty
string when length is zero.
- `ceil(1/0)` and `floor(1/0)` would previously return a large integer
value, rather than infinity. This has been fixed.
Codecov Report
|
apparentlymart
approved these changes
Apr 9, 2020
Contributor
apparentlymart
left a comment
apparentlymart
left a comment
There was a problem hiding this comment.
LGTM! 🌮
This cty upgrade will also take care of the last few things for our switch from Unicode 9 to Unicode 10 in the configuration language, but I already wrote a changelog entry covering that when I merged the corresponding HCL-upgrade PR so I don't think we'll need to say anything additional about it.
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes several bugs:
substr("abc", 0, 0)would previously return"abc", despite the length argument being0. This has been changed to return an empty string when length is zero. Fixes substr("x", 0, 0) returns "x" instead of "" #24318.ceil(1/0)andfloor(1/0)would previously return a large integer value, rather than infinity. This has been fixed. Fixes lang: floor and ceil functions produce incorrect result for positive and negative infinity #21463.