command: Warn instead of error for empty output#26036
Conversation
When the output subcommand is called with no arguments, and there are no outputs to show, we previously rendered an error message but returned a non-error status code. This is confusing. This commit changes the text UI to use a warning diagnostic, which makes it clearer that this is a non-error situation. We do not change the exit code or the text of the warning, so hopefully this is not considered a breaking change.
Codecov Report
|
pselle
left a comment
pselle
left a comment
There was a problem hiding this comment.
I agree that this is non-breaking, and reading some of the discussion on the linked issue, it was helpful in giving context about how returning an error without an error code here is confusing. I'd like someone else to +1 (probably Martin) this this is in the neighborhood of design-of-the-tool. But in general I like it?
|
I'm very happy with this solution! 👍 |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked as resolved and limited conversation to collaborators
4 participants
When the output subcommand is called with no arguments, and there are no outputs to show, we previously rendered an error message but returned a non-error status code. This is confusing.
This commit changes the text UI to use a warning diagnostic, which makes it clearer that this is a non-error situation. We do not change the exit code or the text of the warning, so hopefully this is not considered a breaking change.
Fixes #25956