Skip to content

configs: More interpolation-only expr deprecations#26272

Merged
alisdair merged 1 commit intov0.13from
alisdair/more-interpolation-only-expression-deprecations-0.13
Sep 17, 2020
Merged

configs: More interpolation-only expr deprecations#26272
alisdair merged 1 commit intov0.13from
alisdair/more-interpolation-only-expression-deprecations-0.13

Conversation

@alisdair
Copy link
Copy Markdown
Contributor

Extend the deprecation for interpolation-only expressions to include module calls, data sources, outputs, and locals.

Backport of #26105 to 0.13.

Changelog entry

UPGRADE NOTES:

  • Deprecated interpolation-only expressions are detected in more contexts in addition to resources and provider configurations. Module calls, data sources, outputs, and locals are now also covered. An expression like "${foo}" should be rewritten as just foo.

Extend the deprecation for interpolation-only expressions to include
module calls, data sources, outputs, and locals.
@alisdair alisdair added this to the v0.13.x milestone Sep 16, 2020
@alisdair alisdair requested a review from a team September 16, 2020 20:12
@alisdair alisdair self-assigned this Sep 16, 2020
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 16, 2020

Codecov Report

Merging #26272 into v0.13 will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted Files Coverage Δ
configs/module_call.go 69.23% <100.00%> (+1.66%) ⬆️
configs/named_values.go 67.96% <100.00%> (+0.76%) ⬆️
configs/resource.go 82.08% <100.00%> (+0.27%) ⬆️
internal/providercache/dir.go 70.68% <0.00%> (-5.18%) ⬇️
terraform/evaluate.go 53.71% <0.00%> (+0.43%) ⬆️
dag/walk.go 93.16% <0.00%> (+0.62%) ⬆️
dag/marshal.go 54.44% <0.00%> (+1.11%) ⬆️

Copy link
Copy Markdown
Contributor

@mildwonkey mildwonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@alisdair alisdair merged commit a77ea74 into v0.13 Sep 17, 2020
@alisdair alisdair deleted the alisdair/more-interpolation-only-expression-deprecations-0.13 branch September 17, 2020 16:05
@ghost
Copy link
Copy Markdown

ghost commented Oct 18, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked as resolved and limited conversation to collaborators Oct 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants